Re: [PATCH net-next 14/15] net/mlx5e: Register eswitch-manager VF/SF self-port with switch-id

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] net/mlx5e: duplicated switch_id setup in mlx5e_devlink_port_register()
--

commit 54a79d65d3221b87550e0050ec06b1b9389a1a13
Author: Shay Drory <shayd@nvidia.com>

net/mlx5e: Register eswitch-manager VF/SF self-port with switch-id

This commit populates attrs.switch_id from the system image GUID when
registering a non-PF eswitch manager's self-port so that its uplink netdev
exposes a phys_switch_id matching its managed representors.

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c
> index 8818f65d1fbc4..79adb1ecc4506 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c
> @@ -63,6 +63,11 @@ int mlx5e_devlink_port_register(struct mlx5e_dev *mlx5e_dev,
>  		dl_port_index = mlx5_esw_vport_to_devlink_port_index(mdev,
>  								     MLX5_VPORT_UPLINK);
>  	} else {
> +		if (MLX5_ESWITCH_MANAGER(mdev)) {
> +			mlx5e_devlink_get_port_parent_id(mdev, &ppid);
> +			memcpy(attrs.switch_id.id, ppid.id, ppid.id_len);
> +			attrs.switch_id.id_len = ppid.id_len;
> +		}

[Severity: Low]
This isn't a bug, but in drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c,
mlx5e_devlink_port_register() already has the exact same
MLX5_ESWITCH_MANAGER(mdev) block in the mlx5_core_is_pf(mdev) branch:

	if (mlx5_core_is_pf(mdev)) {
		attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
		attrs.phys.port_number = mlx5_get_dev_index(mdev);
		if (MLX5_ESWITCH_MANAGER(mdev)) {
			mlx5e_devlink_get_port_parent_id(mdev, &ppid);
			memcpy(attrs.switch_id.id, ppid.id, ppid.id_len);
			attrs.switch_id.id_len = ppid.id_len;
		}
		dl_port_index = mlx5_esw_vport_to_devlink_port_index(mdev,
								     MLX5_VPORT_UPLINK);
	}

Since attrs.switch_id is independent of the flavour-specific union in struct
devlink_port_attrs, could the MLX5_ESWITCH_MANAGER(mdev) check be moved
outside the if/else statement to avoid duplicating it in both branches?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103171009.563034-1-tariqt@nvidia.com?part=14