Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Leon Romanovsky" <leon@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v13 05/19] PCI/P2PDMA: Evaluate ACS controls at the path divergence
Date: Thu, 05 Nov 2026 10:21:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-198842@kernel.org> (raw)
In-Reply-To: <20261105-fix-p2p-acs-v4-0-v13-5-3dd065907c3b@nvidia.com>

> From: Leon Romanovsky <leonro@nvidia.com>
> 
> ACS redirect controls below the path divergence reject valid nested
> topologies, where traffic already has only an upstream route. Sibling
> functions can lack an internal peer route even with redirect controls
> clear, so ignoring their shared ports can incorrectly permit bus
> addressing.
> 
> Evaluate directional controls at the divergence and account separately for
> unsupported internal routes between functions sharing a PCIe link. Check
> Upstream Forwarding at every shared Downstream and Root Port only when a
> host route is needed. Reject unreadable controls needed for that route,
> and keep redirect advice when clearing controls restores a direct route.
> 
> Fixes: 52916982af48 ("PCI/P2PDMA: Support peer-to-peer memory")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-fix-p2p-acs-v4-0-v13-0-3dd065907c3b@nvidia.com?part=5


  reply	other threads:[~2026-11-05 10:21 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 10:04 [PATCH v13 00/19] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Leon Romanovsky
2026-11-05 10:04 ` [PATCH v13 01/19] PCI/P2PDMA: Honor device-specific ACS redirection Leon Romanovsky
2026-11-05 10:26   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 02/19] PCI/P2PDMA: Document the TLP attribute assumptions Leon Romanovsky
2026-11-05 10:15   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 03/19] PCI/P2PDMA: Derive routing from directional ACS controls Leon Romanovsky
2026-11-05 10:21   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 04/19] PCI: Reject unreadable ACS controls in isolation checks Leon Romanovsky
2026-11-05 10:13   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 05/19] PCI/P2PDMA: Evaluate ACS controls at the path divergence Leon Romanovsky
2026-11-05 10:21   ` sashiko-bot [this message]
2026-11-05 10:04 ` [PATCH v13 06/19] PCI/P2PDMA: Document directional ACS routing Leon Romanovsky
2026-11-05 10:11   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 07/19] PCI/P2PDMA: Collect the path's ACS controls before deciding Leon Romanovsky
2026-11-05 10:15   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 08/19] PCI/P2PDMA: Answer routing per TLP class Leon Romanovsky
2026-11-05 10:22   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 09/19] PCI/P2PDMA: Route Relaxed Ordering Completions directly Leon Romanovsky
2026-11-05 10:12   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 10/19] PCI/P2PDMA: Reject Translated Requests blocked by Translation Blocking Leon Romanovsky
2026-11-05 10:18   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 11/19] PCI/P2PDMA: Route Translated Requests under Direct Translated P2P Leon Romanovsky
2026-11-05 10:14   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 12/19] PCI/P2PDMA: Log detailed ACS routing diagnostics Leon Romanovsky
2026-11-05 10:19   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 13/19] PCI/P2PDMA: Add KUnit tests for the ACS routing decisions Leon Romanovsky
2026-11-05 10:16   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 14/19] PCI/P2PDMA: Test the ACS P2P routing walk Leon Romanovsky
2026-11-05 10:17   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 15/19] PCI: Add KUnit coverage for ACS isolation checks Leon Romanovsky
2026-11-05 10:17   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 16/19] PCI/P2PDMA: Document TLP-class routing Leon Romanovsky
2026-11-05 10:16   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 17/19] PCI/P2PDMA: Let a client declare that it selects ATS per mapping Leon Romanovsky
2026-11-05 10:17   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 18/19] PCI/P2PDMA: Evaluate the ATS path for clients with ATS enabled Leon Romanovsky
2026-11-05 10:34   ` sashiko-bot
2026-11-05 10:04 ` [PATCH v13 19/19] PCI/P2PDMA: Test the routing of " Leon Romanovsky
2026-11-05 10:20   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-198842@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox