Re: [PATCH rdma-next v2] RDMA/mlx5: Warn on pending software WCs at CQ destroy

[sashiko-bot@kernel.org]

> Software WCs generated by mlx5_ib_generate_wc() are allocated, linked
> onto cq->wc_list and only freed when a consumer polls them. Anything
> still on the list when the CQ is destroyed would be leaked.
> 
> This cannot happen with in-tree users. Soft WCs are only generated for
> send completions of the mlx5 GSI QP, and ib_mad is the only creator of
> GSI QPs. Every MAD send holds a reference on its agent until its send
> completion has been processed, unregister_mad_agent() waits for those
> references, and ib_mad_port_close() frees the CQ only after all agents
> on the port are unregistered. Since poll_soft_wc() frees each soft WC
> before its completion handler runs, wc_list is empty by then.
> 
> Add a WARN_ON() so that a consumer violating this assumption is caught
> instead of silently leaking memory.
> 
> Signed-off-by: Edward Srouji <edwards@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108-free-sw-wcs-v2-1-d1e6d80d2746@nvidia.com?part=1