Re: [PATCH net-next 04/14] ipv6: annotate data-races around icmpv6 reply sysctls

[sashiko-bot@kernel.org]

> icmpv6_echo_ignore_all, icmpv6_echo_ignore_multicast,
> icmpv6_echo_ignore_anycast, anycast_src_echo_reply and fwmark_reflect are
> read without any lock while their sysctl handlers update them with
> WRITE_ONCE(). Add READ_ONCE() to the readers.
> 
> KCSAN reports it when net.ipv6.icmp.echo_ignore_all is changed while
> ICMPv6 echo requests are received:
> 
>   BUG: KCSAN: data-race in icmpv6_rcv / proc_dou8vec_minmax
> 
>   write (marked) to 0xffffffff8ee2940d of 1 bytes by task 504 on cpu 0:
>    proc_dou8vec_minmax+0x1ab/0x1f0
>    proc_sys_call_handler+0x282/0x3a0
>    proc_sys_write+0x13/0x20
>    ...
> 
>   read to 0xffffffff8ee2940d of 1 bytes by interrupt on cpu 3:
>    icmpv6_rcv+0x99d/0xd40
>    ip6_protocol_deliver_rcu+0x787/0x9a0
>    ip6_input_finish+0xb0/0x1b0
>    ip6_input+0xa8/0x250
>    ipv6_rcv+0x14b/0x1c0
>    __netif_receive_skb_one_core+0x8f/0xe0
>    ...
> 
>   value changed: 0x01 -> 0x00
> 
> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109025425.328445-1-jiayuan.chen@linux.dev?part=4