Re: [RFC net-next 3/7] net/mlx5e: kTLS, Post TX context params only for skbs that use them

[sashiko-bot@kernel.org]

> A new kTLS TX context is installed by static and progress params that
> the driver posts for the connection's first skb:
> mlx5e_ktls_handle_tx_skb() posts them before it checks the skb's
> sequence. That skb may not use the context though: a pass-through skb,
> which ends before the offload start marker (SKIP_NO_DATA), e.g. TCP data
> that was queued before the socket was offloaded.
> 
> A pass-through skb carries no data for the device to encrypt, and is not
> tied to the TX queue of the connection's data. For example, when netem
> on its TX queue delays it, skb_orphan_partial() releases its
> sk_wmem_alloc charge, which lets the socket move to another TX queue
> meanwhile. The params are then posted on one SQ and the connection's
> data on another, with no ordering between them, and the data can be
> encrypted before the TIS is installed, e.g. with the key of the previous
> connection that used a TIS from the pool.
> [ ... ]
> 
> Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
> Reported-by: Rishikesh Jethwani <rjethwani@everpuredata.com>
> Closes: https://lore.kernel.org/netdev/CAKaoeS1hj9XuM7ojLBCjGA=EXc2M-b+eRjC2Sk=8L_8XYeJ18w@mail.gmail.com/
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109114734.2087878-1-tariqt@nvidia.com?part=3