Re: [PATCH] RDMA/irdma: publish APBVT entries after hardware setup

[sashiko-bot@kernel.org]

> irdma_add_apbvt() inserts a new entry into apbvt_hash_tbl before
> sending the CQP command that creates the hardware entry. If the command
> fails, the entry is freed without being removed from the hash table. A
> later lookup of the same port traverses the freed entry.
> 
> Removing the entry on failure is not sufficient because another thread
> can find it and increment use_cnt while the CQP command is in progress.
> 
> Serialize APBVT additions and publish new entries only after the hardware
> command succeeds. Since the allocation no longer runs under apbvt_lock,
> use GFP_KERNEL.
> 
> The issue was found by static analysis and confirmed with a KASAN
> reproducer that forces the CQP failure and retries the same port.
> 
> [ ... ]
>  init_module+0x210/0xff0 [irdma_apbvt_repro]
> 
> Fixes: 44d9e52977a1 ("RDMA/irdma: Implement device initialization definitions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jaeyeong Lee <lee@jaeyeong.cc>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111092505.3121847-1-lee@jaeyeong.cc?part=1