Re: [PATCH V1 rdma-next 16/24] RDMA/core: Set the CQ comp_handler after its poll context is set up

[sashiko-bot@kernel.org]

> __ib_alloc_cq() sets comp_handler before it initializes the poll context
> the handler schedules, and for the workqueue contexts it arms the CQ
> before setting comp_wq. The CQ is reachable from the completion
> interrupt once ops.create_cq() returns, so a completion event raised in
> that window would schedule an uninitialized irq_poll or work, or queue
> work on a NULL workqueue. A conforming device raises no event for a new,
> empty CQ, but nothing in the core relies on that.
> 
> Initialize the poll context first, then set comp_handler, and arm the CQ
> only after that.
> 
> Fixes: 14d3a3b2498e ("IB: add a proper completion queue abstraction")
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110134320.34408-1-yishaih@nvidia.com?part=16