Re: [PATCH rdma-next v2 1/3] RDMA/mlx5: Respect pgsz_bitmap when reducing the DEVX UMEM page size

[sashiko-bot@kernel.org]

> devx_umem_find_best_pgsize() starts from the largest usable page size
> allowed by the user's pgsz_bitmap and halves it until the umem starts
> on a page boundary and its length is a multiple of the page size. The
> halving ignores pgsz_bitmap, so the umem can be created with a page
> size userspace did not allow, although the bitmap is meant to reflect
> the HW limits of the intended use of the umem.
> 
> Step down to the next smaller size in pgsz_bitmap instead, and fail
> the registration if none is left. The default bitmap includes every
> power-of-two page size from 4K up, so the result is unchanged when
> userspace does not pass one.
> 
> The Sashiko AI reviewer found this while reviewing another DEVX UMEM
> patch.
> 
> Fixes: 7610ab57de56 ("RDMA/mlx5: Allow larger pages in DevX umem")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/linux-rdma/sashiko-outbox-205134@kernel.org/
> Signed-off-by: Edward Srouji <edwards@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-devx-umem-mailbox-overflow-v2-0-1e7ca8237b58@nvidia.com?part=1