From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next V2 2/2] net/mlx5e: Batch ICOSQ trigger RCU synchronization
Date: Wed, 11 Nov 2026 18:51:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-209499@kernel.org> (raw)
In-Reply-To: <20261110185005.2932568-3-tariqt@nvidia.com>
> From: Carolina Jubran <cjubran@nvidia.com>
>
> During channel activation, mlx5e_activate_channels() triggers the ICOSQ
> once for every channel in order to kick NAPI. mlx5e_trigger_napi_icosq()
> sets MLX5E_SQ_STATE_LOCK_NEEDED and waits for an RCU grace period before
> serializing the trigger with ICOSQ users in NAPI context.
>
> Mark all channel ICOSQs as requiring locking first, wait for a single
> grace period, and then trigger all of them.
>
> Keep mlx5e_trigger_napi_icosq() with its existing synchronization
> semantics for standalone callers.
>
> 248 channels, rcu_normal=1, ip link set eth2 up:
> Before: 3.095s
> After: 1.794s (~1.7x faster)
>
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110185005.2932568-1-tariqt@nvidia.com?part=2
prev parent reply other threads:[~2026-11-11 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 18:50 [PATCH net-next V2 0/2] net/mlx5e: Batch RCU grace periods on channel open and close Tariq Toukan
2026-11-10 18:50 ` [PATCH net-next V2 1/2] net/mlx5e: Batch NAPI RCU grace periods on channel close Tariq Toukan
2026-11-11 18:51 ` sashiko-bot
2026-11-10 18:50 ` [PATCH net-next V2 2/2] net/mlx5e: Batch ICOSQ trigger RCU synchronization Tariq Toukan
2026-11-11 18:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209499@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox