Re: [PATCH V3] driver core: auxiliary bus: Fix IRQ sysfs directory cleanup

[sashiko-bot@kernel.org]

> From: Amir Tzin <amirtz@nvidia.com>
> 
> In case an auxiliary device with IRQs directory is unbound, the
> directory is released, but auxdev->sysfs.irq_dir_exists remains true.
> This leads to a failure recreating the directory on bind.
> 
> [] mlx5_core.sf mlx5_core.sf.2: mlx5_irq_affinity_request:167:(pid 1939):
>    Failed to create sysfs entry for irq 56, ret = -2
> [] mlx5_core.sf mlx5_core.sf.2: mlx5_eq_table_create:1195:(pid 1939):
>    Failed to create async EQs
> [] mlx5_core.sf mlx5_core.sf.2: mlx5_load:1362:(pid 1939):
>    Failed to create EQs
> 
> The irqs directory state is described by three pieces: the sysfs group,
> the irq_dir_exists flag and the irqs xarray. Currently, only the sysfs
> group removal is managed by the devres API, and on unbind the group is
> removed while the flag and xarray are left intact. Thus, a subsequent
> bind sees irq_dir_exists still set and skips recreating the directory.
> 
> Manage all three under a single release function passed to
> devm_add_action_or_reset(), so the whole directory state is created and
> destroyed as a unit.
> 
> Fixes: a808878308a8 ("driver core: auxiliary bus: show auxiliary device IRQs")
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Amir Tzin <amirtz@nvidia.com>
> Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112081319.3466442-1-tariqt@nvidia.com?part=1