From: sashiko-bot@kernel.org
To: "Allison Henderson" <achender@kernel.org>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v12 02/12] net/rds: ib: refuse to attach a connection to a device being removed
Date: Fri, 13 Nov 2026 05:05:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-212191@kernel.org> (raw)
In-Reply-To: <20261113044355.2932029-3-achender@kernel.org>
> rds_ib_remove_one() drops every connection on the device's conn_list
> in rds_ib_dev_shutdown(), then clears the client data so that no new
> connect can find the device. A connect that is already past
> rds_ib_get_client_data() when the walk runs is not covered by either:
> rds_ib_setup_qp() goes on to rds_ib_add_conn(), which moves the
> connection onto the conn_list the walk has just finished with, and
> builds a QP on a device that is on its way out.
>
> On a hot removal the rdma_cm still catches that: its own client
> removal runs after RDS's and delivers RDMA_CM_EVENT_DEVICE_REMOVAL to
> the connection's id, whose drop shuts the connection down and returns
> it to ib_nodev_conns. On module unload there is no such event - the
> device stays registered - and rds_destroy_pending() is already true,
> so every drop short of a destroy returns early. Nothing drops that
> connection then: the device's shutdown walk is over, and the
> [ ... ]
> rds_ib_add_conn().
>
> Fixes: fc19de38be92 ("RDS/IB: disconnect when IB devices are removed")
> Assisted-by: Claude-Code:claude-fable-5
> Signed-off-by: Allison Henderson <achender@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113044355.2932029-1-achender@kernel.org?part=2
next prev parent reply other threads:[~2026-11-13 5:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 4:43 [PATCH net-next v12 00/12] net/rds: make connection lifetime reference-counted Allison Henderson
2026-11-13 4:43 ` [PATCH net-next v12 01/12] net/rds: undo conn_alloc() the same way on every __rds_conn_create() exit Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 02/12] net/rds: ib: refuse to attach a connection to a device being removed Allison Henderson
2026-11-13 5:05 ` sashiko-bot [this message]
2026-11-13 4:43 ` [PATCH net-next v12 03/12] net/rds: guard every work-requeueing site with rds_destroy_pending() Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 04/12] net/rds: make rds_destroy_pending() report a connection's own destroy Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 05/12] net/rds: split connection destroy into quiesce and kref-governed free Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 06/12] net/rds: unlink transport nodes before a possibly deferred connection free Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 07/12] net/rds: wait for connections to be freed on transport unload Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 08/12] net/rds: hold a connection reference from struct rds_incoming Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 09/12] net/rds: take cp_lock to purge cp_send_queue in the quiesce Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 10/12] net/rds: hold connection references in lookup, sockets and c_passive Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 11/12] net/rds: give cm_id->context a reference on its connection Allison Henderson
2026-11-13 5:05 ` sashiko-bot
2026-11-13 4:43 ` [PATCH net-next v12 12/12] net/rds: drop rds_conn_count in favor of t_conn_count Allison Henderson
2026-11-13 5:05 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212191@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=achender@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox