Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bryam Vargas" <hexlabsecurity@proton.me>
Cc: linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH net] net/smc: check every link before skipping the RMB registration
Date: Fri, 13 Nov 2026 19:17:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-213534@kernel.org> (raw)
In-Reply-To: <20261113-b4-disp-08835f86-v1-1-b2ee1b9b94e2@proton.me>

> From: Bryam Vargas <hexlabsecurity@proton.me>
> 
> smcr_lgr_reg_rmbs() skips the MR registration (its fast path) when the
> RMB is registered on every active link, but the check reads is_reg_mr[]
> at the index of the connection's link for each link it walks. An RMB
> that sits unused in the pool when a link is added is not registered on
> that link. A later connection on the older link that reuses it takes
> the fast path, never registers it on the newer link, and its
> CONFIRM_RKEY still gives the peer an rkey for that link. After a
> failover to the newer link, the peer's RDMA writes into the RMB fail
> with a remote access error, that link goes down too and, with no other
> link left, the link group is terminated.
> 
> Read is_reg_mr[] at each active link's own index, so the fast path is
> taken only when the RMB is registered on all of them.
> 
> Fixes: 4da687448de7 ("net/smc: reduce unnecessary blocking in smcr_lgr_reg_rmbs()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bryam Vargas <hexlabsecurity@proton.me>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-b4-disp-08835f86-v1-1-b2ee1b9b94e2@proton.me?part=1


  reply	other threads:[~2026-11-13 19:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 19:11 [PATCH net] net/smc: check every link before skipping the RMB registration Bryam Vargas via B4 Relay
2026-11-13 19:17 ` sashiko-bot [this message]
2026-11-13 19:17 ` netdev-bot+sinfo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-213534@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=hexlabsecurity@proton.me \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox