From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH mlx5-next 1/3] net/mlx5: Extend nic_cap_reg layout to its full register size
Date: Mon, 16 Nov 2026 14:55:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-217202@kernel.org> (raw)
In-Reply-To: <20261116144554.1194389-2-tariqt@nvidia.com>
> From: Moshe Shemesh <moshe@nvidia.com>
>
> Struct mlx5_ifc_nic_cap_reg_bits describes only the first 4 dwords of
> NIC_CAP_REG, while the register itself is 32 dwords long. The driver
> reads the register through mlx5_core_access_reg(), which derives the
> access length from the struct size, so today it issues a partial read.
> Partial reads of a register using access reg command are accepted by
> the device, hence nothing is broken and no fix is needed.
>
> It does mean, though, that naming any field deeper in the register
> changes the length requested on the wire as a side effect. Describe
> NIC_CAP_REG up to its full size, as is done for the other register
> layouts in mlx5_ifc.h, so that the access length is fixed and further
> fields can be added without altering it.
>
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Shay Drori <shayd@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116144554.1194389-1-tariqt@nvidia.com?part=1
next prev parent reply other threads:[~2026-11-16 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 14:45 [PATCH mlx5-next 0/3] mlx5-next updates 2026-11-16 Tariq Toukan
2026-11-16 14:45 ` [PATCH mlx5-next 1/3] net/mlx5: Extend nic_cap_reg layout to its full register size Tariq Toukan
2026-11-16 14:55 ` sashiko-bot [this message]
2026-11-16 14:45 ` [PATCH mlx5-next 2/3] net/mlx5: Add IFC bits for SW RoCE monitor matched packets counter Tariq Toukan
2026-11-16 14:55 ` sashiko-bot
2026-11-16 14:45 ` [PATCH mlx5-next 3/3] net/mlx5: Add MLX5_PCI_PF_TYPE_QUERY_PF to mlx5_ifc Tariq Toukan
2026-11-16 14:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217202@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox