Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jiayuan Chen" <jiayuan.chen@linux.dev>
Cc: linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH net-next v2 3/5] mptcp: annotate data-races around pernet sysctls
Date: Wed, 18 Nov 2026 05:00:21 +0000	[thread overview]
Message-ID: <sashiko-outbox-220133@kernel.org> (raw)
In-Reply-To: <20261118045137.174026-4-jiayuan.chen@linux.dev>

> enabled, add_addr_timeout, checksum_enabled, allow_join_initial_addr_port,
> stale_loss_cnt, close_timeout, pm_type and syn_retrans_before_tcp_fallback
> are read by their ctrl.c helpers without any lock while the sysctl
> handlers update them with WRITE_ONCE(), and the path_manager handler
> stores pm_type with a plain write. Add READ_ONCE() to the readers and
> WRITE_ONCE() to that handler.
> 
> KCSAN reports it when net.mptcp.enabled is changed while MPTCP sockets
> are being created:
> 
>   BUG: KCSAN: data-race in mptcp_is_enabled / proc_dou8vec_minmax
> 
>   write (marked) to 0xffff8d724248abc9 of 1 bytes by task 733 on cpu 3:
>    proc_dou8vec_minmax+0x1ab/0x1f0
>    proc_sys_call_handler+0x282/0x3a0
>    proc_sys_write+0x13/0x20
>    ...
> 
>   read to 0xffff8d724248abc9 of 1 bytes by task 735 on cpu 1:
>    mptcp_is_enabled+0x33/0x50
>    mptcp_init_sock+0x35/0x300
>    inet_create+0x4a6/0x8e0
>    ...
> 
>   value changed: 0x00 -> 0x01
> 
> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118045137.174026-1-jiayuan.chen@linux.dev?part=3


  reply	other threads:[~2026-11-18  5:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  4:51 [PATCH net-next v2 0/5] net: annotate data-races around sysctl knobs Jiayuan Chen
2026-11-18  4:51 ` [PATCH net-next v2 1/5] inet: frags: annotate data-races around fqdir->timeout and fqdir->max_dist Jiayuan Chen
2026-11-18  5:00   ` sashiko-bot
2026-11-18  4:51 ` [PATCH net-next v2 2/5] ipv6: annotate data-races around icmpv6 reply sysctls Jiayuan Chen
2026-11-18  5:00   ` sashiko-bot
2026-11-18  4:51 ` [PATCH net-next v2 3/5] mptcp: annotate data-races around pernet sysctls Jiayuan Chen
2026-11-18  5:00   ` sashiko-bot [this message]
2026-11-18  4:51 ` [PATCH net-next v2 4/5] rds: annotate data-races around core rds sysctls Jiayuan Chen
2026-11-18  5:00   ` sashiko-bot
2026-11-18  4:51 ` [PATCH net-next v2 5/5] net/smc: annotate data-races around smc sysctls Jiayuan Chen
2026-11-18  5:00   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220133@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=jiayuan.chen@linux.dev \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox