Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexandre Cassen" <acassen@corp.free.fr>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v2 06/10] net/sched: cls_flower: add enc_key_id mask
Date: Wed, 18 Nov 2026 09:29:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-220567@kernel.org> (raw)
In-Reply-To: <20261117092915.255194-7-acassen@corp.free.fr>

> Flower only matches enc_key_id exactly. A block of tunnel keys takes one
> filter per key. Add an optional mask. Without one the match stays exact.
> 
>   tc filter add dev <dev> ingress protocol ip flower \
>       enc_key_id 0x100/0xf00 action ...
> 
> cxgb4, mlx5 and nfp program the mask. sfc does when its firmware supports
> it. hns3 and ice reject a partial one. The previous patches make bnxt and
> mlx5 tunnel mapping reject it too. i40e and iavf never program the value
> of enc_key_id, with or without this patch.
> 
> Hardware holding a 24 bit VNI truncates the mask too. This is correct when
> the key fits the VNI. The previous patches enforce this on cxgb4, nfp and
> mlx5. On cxgb4 a mask without a VNI bit would also drop the tunnel match,
> and the cxgb4 patch refuses it.
> 
> Signed-off-by: Alexandre Cassen <acassen@corp.free.fr>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117092915.255194-1-acassen@corp.free.fr?part=6


  reply	other threads:[~2026-11-18  9:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:29 [PATCH net-next v2 00/10] tc flower: tunnel key partitioning for RX queue steering Alexandre Cassen
2026-11-17  9:29 ` [PATCH net-next v2 01/10] bnxt_en: require an exact tunnel id in TC flows Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 02/10] cxgb4: flower: refuse a tunnel key wider than the VNI Alexandre Cassen
2026-11-17 14:05   ` Potnuri Bharat Teja
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 03/10] nfp: " Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 04/10] net/mlx5e: TC, " Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 05/10] net/mlx5e: TC, reject a partial tunnel key with tunnel mapping Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 06/10] net/sched: cls_flower: add enc_key_id mask Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot [this message]
2026-11-17  9:29 ` [PATCH net-next v2 07/10] selftests: forwarding: tc_flower: test the " Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 08/10] net/mlx5e: TC, offload RX queue mapping in NIC flows Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 09/10] net/mlx5e: TC, match the tunnel key without a tunnel device Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot
2026-11-17  9:29 ` [PATCH net-next v2 10/10] docs: networking: describe tunnel key partitioning in TC queue filtering Alexandre Cassen
2026-11-18  9:29   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220567@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acassen@corp.free.fr \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox