From: sashiko-bot@kernel.org
To: "Sahil Chandna" <sahilchandna@linux.microsoft.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v4] net: mana: Avoid waiting on dead HWC after device reset
Date: Wed, 18 Nov 2026 09:31:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-220575@kernel.org> (raw)
In-Reply-To: <20261118091436.3985155-1-sahilchandna@linux.microsoft.com>
> After device reset is issued due to TX drain timeout in
> mana_dealloc_queues(), hardware channel (HWC) state is non-functional.
> However, the driver continues to issue HWC commands (mana_disable_vport_rx,
> mana_fence_rqs, mana_destroy_wq_obj) which will each wait for a
> completion that never arrives.
>
> The first such command (MANA_CONFIG_VPORT_RX) blocks for the full
> hwc_timeout (60s as set by the firmware on the tested system), after
> which the timeout is reduced to 1 ms for subsequent commands. This
> causes the calling thread to hold the RTNL lock for over 180 seconds
> (120s TX drain + 60s HWC timeout), triggering hung task warnings and
> blocking all other networking operations on the system.
>
> Fix this by:
> 1. Replacing the sleep-based TX drain with a CQE polling approach:
> [ ... ]
> Fixes: a7dfeda6fdec ("net: mana: Fix MANA VF unload when hardware is unresponsive")
> Cc: stable@vger.kernel.org
> Co-developed-by: Dipayaan Roy <dipayanroy@linux.microsoft.com>
> Signed-off-by: Dipayaan Roy <dipayanroy@linux.microsoft.com>
> Signed-off-by: Sahil Chandna <sahilchandna@linux.microsoft.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118091436.3985155-1-sahilchandna@linux.microsoft.com?part=1
prev parent reply other threads:[~2026-11-18 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:14 [PATCH net v4] net: mana: Avoid waiting on dead HWC after device reset Sahil Chandna
2026-11-18 9:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220575@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sahilchandna@linux.microsoft.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox