Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Abdifatah Suruur" <suruurism@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH 2/2] IB/hfi1: reject writable SUBCTXT_EGRBUF mmap
Date: Wed, 18 Nov 2026 13:35:59 +0000	[thread overview]
Message-ID: <sashiko-outbox-221032@kernel.org> (raw)
In-Reply-To: <20261118131948.28748-2-suruurism@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] IB/hfi1: rejecting VM_WRITE on SUBCTXT_EGRBUF in
  hfi1_file_mmap() breaks subcontexts
- [Low] IB/hfi1: inaccurate Fixes trailer citing 12220267645c for
  hfi1_file_mmap()
--

commit 0342c207f57f73ef2cbfe9cff3f4ce685d284272
Author: Abdifatah Suruur <suruurism@gmail.com>

> IB/hfi1: reject writable SUBCTXT_EGRBUF mmap
>
> hfi1_file_mmap() clears VM_MAYWRITE for the SUBCTXT_EGRBUF mapping, but
> never checks whether the caller requested VM_WRITE in the first place.
> A caller can pass PROT_WRITE to mmap() and get a writable mapping of
> the read-only shared eager receive buffers, unlike RCV_EGRBUF which
> rejects the request with -EPERM.
>
> Add the missing VM_WRITE check, matching the other read-only mmap cases
> in this function.
>
> Fixes: 12220267645c ("IB/hfi: Protect against writable mmap")
> Cc: stable@vger.kernel.org
> Signed-off-by: Abdifatah Suruur <suruurism@gmail.com>

[Severity: Low]
12220267645c ("IB/hfi: Protect against writable mmap") only added a
VM_WRITE | VM_EXEC check to the STATUS case in hfi1_file_mmap().  The
SUBCTXT_EGRBUF handling dates back to 7724105686e7 ("IB/hfi1: add driver
files").

> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c
> index 779dbe32c69da..412c134e5fb2a 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -526,6 +526,10 @@ static int hfi1_file_mmap(struct file *fp, struct vm_area_struct *vma)
>  		is_vmalloc = 1;
>  		break;
>  	case SUBCTXT_EGRBUF:
> +		if (flags & VM_WRITE) {
> +			ret = -EPERM;
> +			goto done;
> +		}
>  		memvirt = uctxt->subctxt_rcvegrbuf;
>  		memlen = uctxt->egrbufs.size * uctxt->subctxt_cnt;
>  		flags &= ~VM_MAYWRITE;

[Severity: High]
Does rejecting VM_WRITE on SUBCTXT_EGRBUF break userspace context sharing?

Unlike RCV_EGRBUF, which maps DMA buffers written by the HFI1 chip,
uctxt->subctxt_rcvegrbuf is a vmalloc_user() buffer allocated in
setup_subctxt() for userspace subcontexts sharing a hardware context, and
neither hardware nor the kernel ever writes to it.  The process polling
the hardware receive queue forwards eager packets to sibling subcontexts
by writing them into this shared mapping (alongside SUBCTXT_RCV_HDRQ and
SUBCTXT_UREGS), so userspace maps SUBCTXT_EGRBUF with PROT_READ |
PROT_WRITE.  Rejecting VM_WRITE causes subcontext initialization to fail
with -EPERM and leaves nothing able to populate uctxt->subctxt_rcvegrbuf.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118131948.28748-1-suruurism@gmail.com?part=2

  reply	other threads:[~2026-11-18 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:19 [PATCH 1/2] IB/hfi1: clear VM_MAYWRITE on read-only STATUS mmap Abdifatah Suruur
2026-11-18 13:19 ` [PATCH 2/2] IB/hfi1: reject writable SUBCTXT_EGRBUF mmap Abdifatah Suruur
2026-11-18 13:35   ` sashiko-bot [this message]
2026-11-18 13:36   ` Abdifatah Suruur
2026-11-18 13:24 ` [PATCH 1/2] IB/hfi1: clear VM_MAYWRITE on read-only STATUS mmap sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221032@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=suruurism@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox