Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net/mlx5e: SHAMPO: Do not merge packets with different kTLS RX state
Date: Wed, 18 Nov 2026 14:51:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-221259@kernel.org> (raw)
In-Reply-To: <20261118144042.1916204-1-tariqt@nvidia.com>

> HW-GRO (SHAMPO) sessions are not terminated by HW when the kTLS RX
> offload indication in the CQE changes. The driver applies the offload
> metadata of the first packet in the session only, so ciphertext and
> plaintext can end up in the same skb under a single skb->decrypted
> indication, and resync requests carried by non-first packets are lost.
> 
> Do not merge a CQE whose decryption state differs from skb->decrypted,
> which the first packet of the session sets. Never merge a CQE that
> carries a resync request or a TLS error, so that each of them starts a
> session and is handled.
> 
> The failure was reproduced on ConnectX-7 with HW GRO and kTLS RX offload
> on and 0.3% loss added by netem on the sender's egress: TlsDecryptError
> increased and the receiving sockets failed with EBADMSG. With this
> patch, TlsDecryptError stays 0.
> 
> Fixes: 92552d3abd32 ("net/mlx5e: HW_GRO cqe handler implementation")
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118144042.1916204-1-tariqt@nvidia.com?part=1


      reply	other threads:[~2026-11-18 14:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:40 [PATCH net] net/mlx5e: SHAMPO: Do not merge packets with different kTLS RX state Tariq Toukan
2026-11-18 14:51 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221259@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox