Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next V3 1/2] net/mlx5e: Batch NAPI RCU grace periods on channel close
Date: Thu, 19 Nov 2026 10:57:34 +0000	[thread overview]
Message-ID: <sashiko-outbox-222994@kernel.org> (raw)
In-Reply-To: <20261119103935.2190627-2-tariqt@nvidia.com>

> From: Carolina Jubran <cjubran@nvidia.com>
> 
> Channel close currently invokes synchronize_net() repeatedly while
> tearing down each channel. RQ, ICOSQ, TX SQ and NAPI teardown each
> require a grace period, causing the number of waits to scale with the
> number of channels. TX SQ teardown adds a wait for each traffic class,
> while XDP and QoS can add further calls.
> 
> Batch these waits across all channels. Split channel deactivate and
> close into pre_sync and post_sync phases. First clear the ENABLED state
> on all queues, then wait for a single grace period before continuing
> with the teardown. Once NAPI is disabled on all channels, wait for one
> more grace period, as the poll may still arm the CQs after
> napi_complete_done().
> 
> Similarly, close the queues and unlink all NAPI instances with
> __netif_napi_del_locked(), issue one synchronize_net() after all of
> them have been unlinked, and only then free the channels.
> 
> Keep the existing per object synchronize_net() calls for single queue
> paths. Drop the one in mlx5e_close_xdpsq(), as its callers already
> wait for a grace period or run before NAPI is enabled.
> 
> 248 channels, rcu_normal=1, ip link set eth2 down:
> Before: 11.837s
> After:   0.817s (~14.5x faster)
> 
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119103935.2190627-1-tariqt@nvidia.com?part=1


  reply	other threads:[~2026-11-19 10:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:39 [PATCH net-next V3 0/2] net/mlx5e: Batch RCU grace periods on channel open and close Tariq Toukan
2026-11-19 10:39 ` [PATCH net-next V3 1/2] net/mlx5e: Batch NAPI RCU grace periods on channel close Tariq Toukan
2026-11-19 10:57   ` sashiko-bot [this message]
2026-11-19 10:39 ` [PATCH net-next V3 2/2] net/mlx5e: Batch ICOSQ trigger RCU synchronization Tariq Toukan
2026-11-19 10:57   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222994@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox