Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Todd Freed" <toddfreed@meta.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v2 04/12] psp: add support for socket-less psp associations
Date: Fri, 20 Nov 2026 01:31:57 +0000	[thread overview]
Message-ID: <sashiko-outbox-224311@kernel.org> (raw)
In-Reply-To: <20261119013103.1092559-5-toddfreed@meta.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] psp: missing kernel-doc entry for sockless_assocs in struct
  psp_dev
--

commit c762835dd18f3e2173c0b94d65dae1e6c0d9077f
Author: Todd Freed <toddfreed@meta.com>

psp: add support for socket-less psp associations

This commit adds netlink commands and an ID-based registry to support
socket-less PSP Tx associations and Rx SPI allocations.

> diff --git a/include/net/psp/types.h b/include/net/psp/types.h
> index b8905efbd604e..be383f8e65d07 100644
> --- a/include/net/psp/types.h
> +++ b/include/net/psp/types.h
> @@ -107,6 +107,7 @@ struct psp_dev {
>  	struct list_head active_assocs;
>  	struct list_head prev_assocs;
>  	struct list_head stale_assocs;
> +	struct list_head sockless_assocs;

[Severity: Low]
struct psp_dev has a kernel-doc comment describing its members, so adding
sockless_assocs without a corresponding @sockless_assocs entry will trigger
a kernel-doc warning under W=1 builds.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119013103.1092559-1-toddfreed@meta.com?part=4

  reply	other threads:[~2026-11-20  1:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  1:30 [PATCH net-next v2 00/12] psp: introduce socket-less associations Todd Freed
2026-11-19  1:30 ` [PATCH net-next v2 01/12] psp: get netns from net_device instead of sock Todd Freed
2026-11-20  1:31   ` sashiko-bot
2026-11-19  1:30 ` [PATCH net-next v2 02/12] psp: take the psp nexthdr from the packet on encap Todd Freed
2026-11-20  1:31   ` sashiko-bot
2026-11-19  1:30 ` [PATCH net-next v2 03/12] psp: declare psp_assoc_set_tx() in psp.h Todd Freed
2026-11-20  1:31   ` sashiko-bot
2026-11-19  1:30 ` [PATCH net-next v2 04/12] psp: add support for socket-less psp associations Todd Freed
2026-11-20  1:31   ` sashiko-bot [this message]
2026-11-19  1:30 ` [PATCH net-next v2 05/12] net: add METADATA_PSP dst to carry a psp association on an skb Todd Freed
2026-11-20  1:31   ` sashiko-bot
2026-11-19  1:30 ` [PATCH net-next v2 06/12] net/sched: add act_psp for psp transport mode Todd Freed
2026-11-20  1:31   ` sashiko-bot
2026-11-19  1:30 ` [PATCH net-next v2 07/12] net/sched: flower: add psp_spi, psp_ver, and psp_dev matches Todd Freed
2026-11-20  1:31   ` sashiko-bot
2026-11-19  1:30 ` [PATCH net-next v2 08/12] selftests: drv-net: psp: test socket-less associations and the tc psp action Todd Freed
2026-11-20  1:32   ` sashiko-bot
2026-11-19  1:31 ` [PATCH net-next v2 09/12] selftests: drv-net: psp: test that software encap on ingress drops Todd Freed
2026-11-20  1:32   ` sashiko-bot
2026-11-19  1:31 ` [PATCH net-next v2 10/12] selftests: tc-testing: run dependsOn probes outside the test namespace Todd Freed
2026-11-20  1:32   ` sashiko-bot
2026-11-19  1:31 ` [PATCH net-next v2 11/12] selftests: tc-testing: add tests for the psp action Todd Freed
2026-11-20  1:32   ` sashiko-bot
2026-11-19  1:31 ` [PATCH net-next v2 12/12] Documentation: networking: psp: document socket-less associations Todd Freed
2026-11-20  1:32   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224311@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=toddfreed@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox