From: sashiko-bot@kernel.org
To: "Changyul Lee" <lcy8047@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v2] net/mlx5e: Skip hairpin entries not ready in debugfs dump
Date: Fri, 20 Nov 2026 02:20:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-224349@kernel.org> (raw)
In-Reply-To: <20261120021557.1630138-1-lcy8047@gmail.com>
> mlx5e_hairpin_flow_add() adds a new hairpin entry to hairpin_tbl and
> drops hairpin_tbl_lock before creating the hairpin, and sets hpe->hp
> only after mlx5e_hairpin_create() returns. Other users of the entry wait
> for res_ready, but debugfs_hairpin_table_dump_show() does not, so
> reading hairpin_table_dump in that window dereferences a NULL hpe->hp,
> or an ERR_PTR when the creation fails.
>
> Skip entries whose res_ready is not completed or whose hp is an error.
>
> Fixes: 8a0594c09610 ("net/mlx5e: Add more information to hairpin table dump")
> Signed-off-by: Changyul Lee <lcy8047@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120021557.1630138-1-lcy8047@gmail.com?part=1
prev parent reply other threads:[~2026-11-20 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 2:15 [PATCH net v2] net/mlx5e: Skip hairpin entries not ready in debugfs dump Changyul Lee
2026-11-20 2:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224349@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lcy8047@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox