From: sashiko-bot@kernel.org
To: "Artemii Mashanov" <ralerrdirsardx@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net: mlx4_en: report the actual RX classification rule count
Date: Sat, 21 Nov 2026 00:23:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-226399@kernel.org> (raw)
In-Reply-To: <20261121001414.724236-1-ralerrdirsardx@gmail.com>
> mlx4_en_get_rxnfc() treats the input rule_cnt as the number of
> rules it needs to find for ETHTOOL_GRXCLSRLALL.
>
> With room for four locations and only one rule installed, the
> ioctl succeeds with rule_cnt still set to four and three extra
> zero entries. When the buffer has too few slots, the ioctl
> succeeds with an incomplete list.
>
> Bound the scan by the rule table size, skip empty slots and
> propagate unexpected lookup errors. Return -EMSGSIZE when the next
> rule cannot fit and set rule_cnt to the number of copied locations
> on success.
>
> The source-extracted ASan/UBSan regression tests passed.
>
> Fixes: 820672812f82 ("net/mlx4_en: Manage flow steering rules with ethtool")
> Signed-off-by: Artemii Mashanov <ralerrdirsardx@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121001414.724236-1-ralerrdirsardx@gmail.com?part=1
prev parent reply other threads:[~2026-11-21 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 0:14 [PATCH net] net: mlx4_en: report the actual RX classification rule count Artemii Mashanov
2026-11-21 0:17 ` netdev-bot+sinfo
2026-11-21 0:23 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226399@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ralerrdirsardx@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox