Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wanhui Fu" <fuwh1120@163.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/hfi1: fix error paths in hfi1_mod_init()
Date: Sat, 21 Nov 2026 09:42:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-226867@kernel.org> (raw)
In-Reply-To: <20261121093901.427880-1-fuwh1120@163.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] IB/hfi1: missing Fixes: trailers on hfi1_mod_init() error-path
  leak fix
--

commit 02fcb0aee43546fd5e57fb0f21507c7ab7cce12f
Author: Wanhui Fu <fuwh1120@163.com>

> IB/hfi1: fix error paths in hfi1_mod_init()
>
> The error path in hfi1_mod_init() is not completed.
> Fix this by add some goto label.
>
> Signed-off-by: Wanhui Fu <fuwh1120@163.com>

[Severity: Low]
Since this fixes module-init error-path leaks introduced by d63730192f59
("IB/hfi1: Reserve and collapse CPU cores for contexts") and 48a615dc00ae
("IB/hfi1: Integrate OPFN into RC transactions"), should this include:

  Fixes: d63730192f59 ("IB/hfi1: Reserve and collapse CPU cores for contexts")
  Fixes: 48a615dc00ae ("IB/hfi1: Integrate OPFN into RC transactions")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121093901.427880-1-fuwh1120@163.com?part=1

      reply	other threads:[~2026-11-21  9:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  9:39 [PATCH] IB/hfi1: fix error paths in hfi1_mod_init() Wanhui Fu
2026-11-21  9:42 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226867@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=fuwh1120@163.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox