Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Andrew Stellman" <astellman@stellman-greene.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-rc] RDMA/rxe: Fix the copy offsets in __rxe_odp_mr_copy()
Date: Sun, 22 Nov 2026 00:48:12 +0000	[thread overview]
Message-ID: <sashiko-outbox-227578@kernel.org> (raw)
In-Reply-To: <20261122003712.91551-1-astellman@stellman-greene.com>

> __rxe_odp_mr_copy() maps each page it copies and copies to or from the
> start of that page. It uses the offset of iova in the first page only
> to size the first copy, not to find where in the page to copy, and it
> does not advance addr after each page, so each page is copied between
> the start of that page and the start of addr.
> 
> Tested as root on rxe loopback (path MTU 1024), three runs, with an
> ODP MR registered 100 bytes into a page:
> 
> - In a 4096-byte RDMA READ or SEND from the start of the MR, the first
>   16 bytes of each of the first three 1024-byte packets were the same
>   as the first 16 bytes of the page, not the data at their offset in
>   the MR.
> - A 32-byte RDMA WRITE to the start of the MR changed 32 of the 100
>   bytes between the start of the page and the MR, which are outside
> [ ... ]
> reviewed by me.
> 
> Fixes: 2fae67ab63db ("RDMA/rxe: Add support for Send/Recv/Write/Read with ODP")
> Cc: stable@vger.kernel.org
> Signed-off-by: Andrew Stellman <astellman@stellman-greene.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122003712.91551-1-astellman@stellman-greene.com?part=1

      reply	other threads:[~2026-11-22  0:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  0:37 [PATCH rdma-rc] RDMA/rxe: Fix the copy offsets in __rxe_odp_mr_copy() Andrew Stellman
2026-11-22  0:48 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227578@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=astellman@stellman-greene.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox