From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8327635E93C for ; Sun, 26 Apr 2026 13:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777209432; cv=none; b=FBEa7mnCDQTy8SvkNwZqlx9Cfia2EVnD69gOj2PY1NSwbe2xgko8qELLLjmmSqwz5aFwON6N5/B0kPGbhB5hzQD349S/WhlGmcePYIWothEefBkhZLM2CDCWj3JXqTYbPyGa/gp1Vfa7Nmpw0v8mcR/nR4Wek9CPQCsPIXh9Ha4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777209432; c=relaxed/simple; bh=x+YYTxWMWBTUs8+xGvsnwglC/8O2WZrLZrMExkdN7Ys=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=rgwljfTYdRNaHUAJokQKs5vv+mgRBVh8bbKlsaW4tRTzdx53gO67Qcl131334gMzUp0WFViOMyX59z2pvkZQ+kEKrnOrzWgR074O6ocmKeDgnvUc8qPXkFIeBZL8EQJ6gfrC9hHXXmSs3n08yvETvZV2PszQjkA3JSjODFqt3Og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gWXx/g9Y; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gWXx/g9Y" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-7b6ae2ea4a1so91626837b3.2 for ; Sun, 26 Apr 2026 06:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777209430; x=1777814230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dHs0YRZHBGD67vbxwSlbpv9/TtMO58IvmgOpPAVdTog=; b=gWXx/g9YJWzTr9dU5q1MVxVahov59zr2J5YpwlKpDyxmtfwWrv33G3VM0f6Sn1dtJi W+PTzQhqR8w0/8cDSPArNGCYtLWJNSX9h6tjmHOhRcjnI4Gka4Qt+42zMmb16/7L8OYJ DiDllHeFE12Xp7+nFJujHP/kuihUI0yRcI2uPC6wCagdlODdwwOKwzYng8d6e6NRS68D CXLp5pFi6QY3qqE9JN5ga8OFztLFg6OrXLrPZyiDQY23+l2SGZUsbFTd/ngy0TJBrYzk lKvwBKAzteKYaXFN6K2OqmQolI1AR07+0FBzXVXIs3fi92oqM3LIl7LN20MAMYFnIhxo FxJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777209430; x=1777814230; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dHs0YRZHBGD67vbxwSlbpv9/TtMO58IvmgOpPAVdTog=; b=GJQgxGqf73AGbmlx33nLEAoN+LQkYDga3H/L+SH6FT9mT4usNnSnGFgnplqAEjBE7P kr3bTw4COgM0eMT5+DqI6BlPxweXUlzPrwRJpaZSS9VueXXxYHOYfItd4c+I6SMcO0V6 /AniSPsX8inX3JZYlypRgZgo84xEMFnIFIqy75Pcpz3+iWgl/3vabkBcD2werQKNJr0f Mu8NcgclX35WGchxxH49gYr4F+2t4op0msA1/AYdHgwWLVyUFpd3+iApz5bCqPf9SHKN jZM6J8i/MoEAUWrpoOe02jkDZJDoAZg+5xCJR9B/Pb5MmMCIlk4F9RkYEsYTNQbsNQEY sqcg== X-Forwarded-Encrypted: i=1; AFNElJ8lkgsnENlGaoYbHjVqGaAS3CfsFZIBusomnjVtB1dCbgua3hgPo37JkprC6PCSS3pHvb/OXfeZrz/U@vger.kernel.org X-Gm-Message-State: AOJu0Ywj04KsL0S1KuTE/9RQQapduAPFt9ZTHxN9qt1x3Ag0PLUhuwBK tu4eXwKQj79/UNIoWZx6zhbQDPOoOfJbVA1zw0EjC0iRVwQQS0wip/tE X-Gm-Gg: AeBDiesguiNnlZvFLjrH7Yhdr1EoX8Kk5pvTYcVAkYZbjlpHw1jOEAKGxLl55aJZdyL iuVVFhPzlxoM54K93nOs5vOk7s+SbuNAqzY9l2dNvG2LOX+uWAT5ltewAKrM5Q6mmZDkuOvUh5l 2T6TH3XKTr1GgjirxEzKtGcjmJOqQ1SIjceoxB+YYE26MLhOqP7T7Zu27wng2uGmXyshHP8yuua 0jS8+42KEHGTf3Sp3wF6Hgv3OkzgZBcFuUEtmT2sOWRvIjx6aVJfANvK4//qw+RyII/D9/A9v/T rESezsvGLmiaspQaKeFToMkv6UXTFuIxYaf4Fu7iAzIZKwI2YR3Z8pfAFLULw8rH6MDeCI0D4Mr pDxE0LCeQehpNH9s+ZroQl6zqJliV9qtSy2v+eMMQR7KhUJJFCIOp3p3EMOxStrMtf8GLhLDjg4 lbngFyQq4jl5zp4y1wfjvd8SLJa0r/gYXZbu38eAoFntlzL3Mja4MLir/n8M42xVJGjfqcGhJJX ze64Q2UlJfo11Y= X-Received: by 2002:a05:690c:e3e9:b0:7b3:9175:30c5 with SMTP id 00721157ae682-7b9ecfdaf23mr390919617b3.35.1777209430402; Sun, 26 Apr 2026 06:17:10 -0700 (PDT) Received: from gmail.com (172.165.85.34.bc.googleusercontent.com. [34.85.165.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b9ee9b22e2sm113515307b3.34.2026.04.26.06.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 06:17:09 -0700 (PDT) Date: Sun, 26 Apr 2026 09:17:08 -0400 From: Willem de Bruijn To: Tariq Toukan , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" Cc: Boris Pismenny , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Daniel Zahka , Willem de Bruijn , Cosmin Ratiu , Raed Salem , Rahul Rameshbabu , Dragos Tatulea , Kees Cook , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman Message-ID: In-Reply-To: <20260426083819.208937-2-tariqt@nvidia.com> References: <20260426083819.208937-1-tariqt@nvidia.com> <20260426083819.208937-2-tariqt@nvidia.com> Subject: Re: [PATCH net V2 1/2] net/mlx5e: psp: Fix invalid access on PSP dev registration fail Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Tariq Toukan wrote: > From: Cosmin Ratiu > > priv->psp->psp is initialized with the PSP device as returned by > psp_dev_create(). This could also return an error, in which case a > future psp_dev_unregister() will result in unpleasantness. > > Avoid that by using a local variable and only saving the PSP device when > registration succeeds. > Also apply some light refactoring of the functions managing the PSP > device in order to make them more readable/safe. This is generally discouraged as it obfuscates the fix. That said, the fix on its own makes sense. > In case psp_dev_create() fails, priv->psp and steering structs are left > in place, but they will be inert. The unchecked access of priv->psp in > mlx5e_psp_offload_handle_rx_skb() won't happen because without a PSP > device, there can be no SAs added and therefore no packets will be > successfully decrypted and be handed off to the SW handler. > > Fixes: 89ee2d92f66c ("net/mlx5e: Support PSP offload functionality") > Signed-off-by: Cosmin Ratiu > Reviewed-by: Dragos Tatulea > Signed-off-by: Tariq Toukan