Re: [PATCH 2/2] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

Bart Van Assche
2016-12-16T12:39:52Z

On 11/23/2016 01:17 AM, Bart Van Assche wrote:
> Ensure that if scsi-mq is enabled that scsi_internal_device_block()
> waits until ongoing shost->hostt->queuecommand() calls have finished.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: James Bottomley <jejb@linux.vnet.ibm.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Doug Ledford <dledford@redhat.com>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 84c9e61..11d082d 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -2872,7 +2872,7 @@ scsi_internal_device_block(struct scsi_device *sdev)
> * request queue.
> */
> if (q->mq_ops) {
> - blk_mq_stop_hw_queues(q);
> + blk_mq_quiesce_queue(q);
> } else {
> spin_lock_irqsave(q->queue_lock, flags);
> blk_stop_queue(q);
>

Hello Martin,

It seems like patch 1/2 of this series is already present in Linus' tree
but patch 2/2 not yet? Can you queue this patch for the next pull
request that will be sent to Linus?

Thanks,

Bart.