Re: [PATCH] iscsi_iser: Re-enable 'iser_pi_guard' module parameter

Bart Van Assche
2018-01-11T17:24:34Z

On Thu, 2018-01-11 at 09:58 -0700, Jason Gunthorpe wrote:
> On Thu, Jan 11, 2018 at 12:04:27AM +0000, Schremmer, Steven wrote:
> > Without the module parameter, there is no way to actually use the CRC guard format.
> > Currently, iscsi_iser_session_create() indicates support for both IP and CRC formats, but
> > sd_dif_config_host() always checks for IP support first, so CRC guard won't be used.
>
> The above paragraph would be a great addition to the commit message.
>
> Still need an ack :)
>
> BTW - not knowing anything, why isn't this knob in the core sd code?
> Other drivers need it too from whatI could see?
>
> We really don't like module parameters in the kernel.

Has it been considered to specify which checksum type to use through iscsiadm
to the iSER initiator driver? I think that would avoid that we have to resurrect
the kernel module parameter.

Thanks,

Bart.