Re: [PATCH] iscsi_iser: Re-enable 'iser_pi_guard' module parameter

Martin K. Petersen
2018-01-16T02:57:07Z

Sagi,

> Isn't a bit backwards that each individual driver needs this knob to
> modify the block layer behavior? I think a better approach would be to
> get rid of the drivers modparams and simply add a block sysfs knob
> that would take the knob guard if supported...

Originally the IP checksum thing was an optimization for a single
device. But others adopted it as well so it grew from being a driver
tweak to a common feature.

I don't have a problem adding a way to toggle it at the block layer. But
it would have to be an additional knob. We can't nuke the module
parameters without breaking a ton of stuff...

--
Martin K. Petersen Oracle Linux Engineering