From: "Martin K. Petersen" <martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: "Schremmer,
Steven" <Steve.Schremmer-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>,
Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-rdma@vger.kernel.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Hannes Reinecke <hare-IBi9RG/b67k@public.gmane.org>,
"Martin K. Petersen"
<martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] iscsi_iser: Re-enable 'iser_pi_guard' module parameter
Date: Mon, 15 Jan 2018 21:57:07 -0500 [thread overview]
Message-ID: <yq1r2qqy0ho.fsf@oracle.com> (raw)
In-Reply-To: <a3d8060a-3926-0ba1-8963-b66d37172027-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> (Sagi Grimberg's message of "Sun, 14 Jan 2018 11:34:20 +0200")
Sagi,
> Isn't a bit backwards that each individual driver needs this knob to
> modify the block layer behavior? I think a better approach would be to
> get rid of the drivers modparams and simply add a block sysfs knob
> that would take the knob guard if supported...
Originally the IP checksum thing was an optimization for a single
device. But others adopted it as well so it grew from being a driver
tweak to a common feature.
I don't have a problem adding a way to toggle it at the block layer. But
it would have to be an additional knob. We can't nuke the module
parameters without breaking a ton of stuff...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-16 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 9:07 [PATCH] iscsi_iser: Re-enable 'iser_pi_guard' module parameter Hannes Reinecke
[not found] ` <1515575256-9949-1-git-send-email-hare-l3A5Bk7waGM@public.gmane.org>
2018-01-10 23:02 ` Jason Gunthorpe
[not found] ` <20180110230240.GR4518-uk2M96/98Pc@public.gmane.org>
2018-01-11 0:04 ` Schremmer, Steven
[not found] ` <CY4PR0601MB35860D768905FF165DB99A048C160-HWnCAiYGO2rYxEunYmvS1/tZqYE1FQh9nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-01-11 16:58 ` Jason Gunthorpe
[not found] ` <20180111165822.GC1309-uk2M96/98Pc@public.gmane.org>
2018-01-11 17:24 ` Bart Van Assche
2018-01-14 9:34 ` Sagi Grimberg
[not found] ` <a3d8060a-3926-0ba1-8963-b66d37172027-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-01-16 2:57 ` Martin K. Petersen [this message]
[not found] ` <yq1r2qqy0ho.fsf-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-16 11:20 ` Hannes Reinecke
[not found] ` <22838a0f-29d5-7351-12d3-05a0948fd0ba-IBi9RG/b67k@public.gmane.org>
2018-01-17 5:09 ` Martin K. Petersen
[not found] ` <yq1d129ul4d.fsf-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-17 9:59 ` Sagi Grimberg
[not found] ` <651bc1dd-f019-637c-1f76-07938b3041ce-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-01-17 20:43 ` Schremmer, Steven
[not found] ` <CY4PR0601MB3586E4314AF5B70DDA8F381A8CE90-HWnCAiYGO2rYxEunYmvS1/tZqYE1FQh9nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-01-18 2:04 ` Martin K. Petersen
2018-01-17 9:54 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r2qqy0ho.fsf@oracle.com \
--to=martin.petersen-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=Steve.Schremmer-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hare-IBi9RG/b67k@public.gmane.org \
--cc=hare-l3A5Bk7waGM@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox