From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] iscsi_iser: Re-enable 'iser_pi_guard' module parameter Date: Mon, 15 Jan 2018 21:57:07 -0500 Message-ID: References: <1515575256-9949-1-git-send-email-hare@suse.de> <20180110230240.GR4518@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Sagi Grimberg's message of "Sun, 14 Jan 2018 11:34:20 +0200") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: "Schremmer, Steven" , Jason Gunthorpe , Hannes Reinecke , Or Gerlitz , Doug Ledford , "linux-rdma@vger.kernel.org" , Hannes Reinecke , "Martin K. Petersen" List-Id: linux-rdma@vger.kernel.org Sagi, > Isn't a bit backwards that each individual driver needs this knob to > modify the block layer behavior? I think a better approach would be to > get rid of the drivers modparams and simply add a block sysfs knob > that would take the knob guard if supported... Originally the IP checksum thing was an optimization for a single device. But others adopted it as well so it grew from being a driver tweak to a common feature. I don't have a problem adding a way to toggle it at the block layer. But it would have to be an additional knob. We can't nuke the module parameters without breaking a ton of stuff... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html