From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECDEC83F2C for ; Tue, 5 Sep 2023 16:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238894AbjIEQHA (ORCPT ); Tue, 5 Sep 2023 12:07:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353660AbjIEHGD (ORCPT ); Tue, 5 Sep 2023 03:06:03 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26BCCCC7 for ; Tue, 5 Sep 2023 00:06:00 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99bf3f59905so322135666b.3 for ; Tue, 05 Sep 2023 00:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693897558; x=1694502358; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r0egsSQOhp01lsRajXoaqFkfpOpTdrOcW/3FTogkqJE=; b=vAxjiCSBsCkAdoMf8nMnm5zEnL0IhBEhafTZ12PRZ2XGm94Fjb+nwvX6VUrKPW1M2j Tq36nrBWyWN9ECjikrTO7MNaJ6KONY+u7vBpH+AlkBWZR8B5gzk//2jPrtW3QqwXXK50 /ltT5Ndd+eIOsAJjSoBvj7LeztqYe7vzXOMZoJJ9iiTadIjawdGgeQ6BBvbx0shzpLeg YRMYfLek5POgprMVoEJGgwrVlZfd3+4Zv17OrgdqNGrRsPdEVhrh/QtKIwP+rgVdp32g Ys6axRnnIn/TCB0TXAUSoZMdnfZuHGra8uqbfVVs91yQ0sWck/qcno+Q3vHOXHkxsoMM PbzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693897558; x=1694502358; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r0egsSQOhp01lsRajXoaqFkfpOpTdrOcW/3FTogkqJE=; b=ItJXgW9Hg10eM1AMEAxsonMizJZRCKyQZzO4RU0J8VSOjkX341sAgz2kfTGdSoSsh3 MF/n6sL0JDJT6wczpc4XwnrGGK6qOusQZ4VnsJATv0hwSMj68OWqIJ6Gc6CIr7NnlIV7 A8isIljE3mINKdec8RqhCLn7cEdtzRgnAMtBmpZQIwNStoZYQf/eq4uwmjdQAY4r7Wun RYF/criry/osHxGbOH9H7hjxtHsqotD7kacPdTYR88xVDrEsaW9YDaexF35mih8VmqpU P0+oNIQbi3C64+MBz0kGYtwoTm3vpYsC/DzRCyjc9GLQtmQkMd1UvaQfhZf6XbGE94dV k4hA== X-Gm-Message-State: AOJu0Yy2YCni9uewR2PAUhoiTHVef6JdT/rtkrLvGXYqnHq5u0pqZFgJ QH/j0Fy+fTpDSSRabRvgEidMs4iKqreV/e0XZr4= X-Google-Smtp-Source: AGHT+IENPgj4JYcgJE/803SIBZBut8q0p3fyKx4XDHoHog4ocY9H4oabYgo7JoL54BlNATQFijL8sw== X-Received: by 2002:a17:906:cc10:b0:9a1:f928:dddc with SMTP id ml16-20020a170906cc1000b009a1f928dddcmr9203400ejb.41.1693897558303; Tue, 05 Sep 2023 00:05:58 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id jj27-20020a170907985b00b009a16975ee5asm7081259ejc.169.2023.09.05.00.05.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 00:05:57 -0700 (PDT) Message-ID: <044bcc91-1145-fee6-ff7c-dca16f83a44d@linaro.org> Date: Tue, 5 Sep 2023 09:05:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc7180: Add ADSP Content-Language: en-US To: Nikita Travkin , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org Cc: David Wronek , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20230905-sc7180-adsp-rproc-v1-0-dfea7699da7b@trvn.ru> <20230905-sc7180-adsp-rproc-v1-4-dfea7699da7b@trvn.ru> From: Krzysztof Kozlowski In-Reply-To: <20230905-sc7180-adsp-rproc-v1-4-dfea7699da7b@trvn.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 05/09/2023 07:47, Nikita Travkin wrote: > + q6afe: apr-service@4 { > + compatible = "qcom,q6afe"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + > + q6afedai: dais { > + compatible = "qcom,q6afe-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <1>; > + }; > + > + q6afecc: cc { It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). > + compatible = "qcom,q6afe-clocks"; > + #clock-cells = <2>; > + }; > + }; > + Best regards, Krzysztof