From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E1DC2D0A3 for ; Mon, 9 Nov 2020 09:42:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D02D206ED for ; Mon, 9 Nov 2020 09:42:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="pclLJ1Dg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbgKIJmS (ORCPT ); Mon, 9 Nov 2020 04:42:18 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:45314 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726176AbgKIJmS (ORCPT ); Mon, 9 Nov 2020 04:42:18 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A99Qblj011711; Mon, 9 Nov 2020 10:42:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=7COCMx7pjIQy0e7OZyvLNSqcwSxASAVRXapE83W9Zk4=; b=pclLJ1DgvrIDbK6q0c256l8fzygECjA9Nx1mPPs24DOLcum477o6kigrIxhqonnc7dWq RM0HpAO84uR8zPh81vXImjqjurnChFVbmbsN2zmWNW1DUOhoUCtxuX5SSv6oMpK52Dza Fzt+R+Ux0NRCUfa2cppCw/IQJOTTgltre38wQ0JfuC1N0M0fllQm2nUC5JGR+pVoggR1 v9o40469BPzp494w8+khgsYB8XTu+tC9DUsfWcGHIFiKCeBHjlhFm+uGxclpCAvHx5c7 pbDGvpAHmkFvK4AinT3W0OWAeLSCYGx/0HLFTxwFjKg9Jd0i3nUTMaDgdkHBWw4Za64J DQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 34nkbms80c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Nov 2020 10:42:16 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B44A010002A; Mon, 9 Nov 2020 10:42:15 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag3node1.st.com [10.75.127.7]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id A9D5C2314F2; Mon, 9 Nov 2020 10:42:15 +0100 (CET) Received: from lmecxl0889.lme.st.com (10.75.127.49) by SFHDAG3NODE1.st.com (10.75.127.7) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 9 Nov 2020 10:42:14 +0100 Subject: Re: [PATCH v2 11/14] remoteproc: Properly deal with a stop request when attached To: Mathieu Poirier , "ohad@wizery.com" , "bjorn.andersson@linaro.org" CC: "linux-remoteproc@vger.kernel.org" References: <20201030195713.1366341-1-mathieu.poirier@linaro.org> <20201030195713.1366341-12-mathieu.poirier@linaro.org> From: Arnaud POULIQUEN Message-ID: <082a9844-8a90-1c2c-7f1b-df1e39b4e004@st.com> Date: Mon, 9 Nov 2020 10:42:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201030195713.1366341-12-mathieu.poirier@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG4NODE1.st.com (10.75.127.10) To SFHDAG3NODE1.st.com (10.75.127.7) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-09_02:2020-11-05,2020-11-09 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 10/30/20 8:57 PM, Mathieu Poirier wrote: > This patch introduces the capability to stop a remote processor > that has been attached to by the remoteproc core. For that to > happen a rproc::ops::stop() operation need to be available. > > Signed-off-by: Mathieu Poirier > Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen Thanks, Arnaud > --- > drivers/remoteproc/remoteproc_cdev.c | 5 +++-- > drivers/remoteproc/remoteproc_core.c | 6 +++++- > drivers/remoteproc/remoteproc_sysfs.c | 5 +++-- > 3 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_cdev.c b/drivers/remoteproc/remoteproc_cdev.c > index b19ea3057bde..d06f8d4919c7 100644 > --- a/drivers/remoteproc/remoteproc_cdev.c > +++ b/drivers/remoteproc/remoteproc_cdev.c > @@ -37,10 +37,11 @@ static ssize_t rproc_cdev_write(struct file *filp, const char __user *buf, size_ > > ret = rproc_boot(rproc); > } else if (!strncmp(cmd, "stop", len)) { > - if (rproc->state != RPROC_RUNNING) > + if (rproc->state != RPROC_RUNNING && > + rproc->state != RPROC_ATTACHED) > return -EINVAL; > > - rproc_shutdown(rproc); > + ret = rproc_shutdown(rproc); > } else { > dev_err(&rproc->dev, "Unrecognized option\n"); > ret = -EINVAL; > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index f58475f6dcab..229fa2cad0bd 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -1642,6 +1642,10 @@ static int rproc_stop(struct rproc *rproc, bool crashed) > struct device *dev = &rproc->dev; > int ret; > > + /* No need to continue if a stop() operation has not been provided */ > + if (!rproc->ops->stop) > + return -EINVAL; > + > /* Stop any subdevices for the remote processor */ > rproc_stop_subdevices(rproc, crashed); > > @@ -1880,7 +1884,7 @@ int rproc_shutdown(struct rproc *rproc) > return ret; > } > > - if (rproc->state != RPROC_RUNNING) { > + if (rproc->state != RPROC_RUNNING && rproc->state != RPROC_ATTACHED) { > ret = -EPERM; > goto out; > } > diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c > index 99ff51fd9707..96751c087585 100644 > --- a/drivers/remoteproc/remoteproc_sysfs.c > +++ b/drivers/remoteproc/remoteproc_sysfs.c > @@ -230,10 +230,11 @@ static ssize_t state_store(struct device *dev, > if (ret) > dev_err(&rproc->dev, "Boot failed: %d\n", ret); > } else if (sysfs_streq(buf, "stop")) { > - if (rproc->state != RPROC_RUNNING) > + if (rproc->state != RPROC_RUNNING && > + rproc->state != RPROC_ATTACHED) > return -EINVAL; > > - rproc_shutdown(rproc); > + ret = rproc_shutdown(rproc); > } else { > dev_err(&rproc->dev, "Unrecognised option: %s\n", buf); > ret = -EINVAL; >