From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E12C43334 for ; Sat, 25 Jun 2022 19:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232852AbiFYTkm (ORCPT ); Sat, 25 Jun 2022 15:40:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbiFYTkm (ORCPT ); Sat, 25 Jun 2022 15:40:42 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E42214099 for ; Sat, 25 Jun 2022 12:40:39 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id fi2so11137770ejb.9 for ; Sat, 25 Jun 2022 12:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TNVYDe807rXFprGHCwJ69e6uyKbChN+0aVPm+tJ314w=; b=vk2/0sZaYEt9w8JdOsnMSV+I1T72oHCtLW+bQC0gx7suA1ceOea6oGvWMuTopIfkSu QW1q3xmFg6IO8Mi796I/KNLPcVo49S13DfInvzO/C6KN89j8buQoz+uAGHa5V7M/8Ok+ mWD4ITTDJ4Sjrwbnjz8xHGe+Ih4d2zgosVaGqQJieAlToUp2TcuMFNuS1RvjcI8ghDzT DcVuHI9AEdpAXO8yI+j5/dzFXQn7Z/2FZnYvk+Kt4yf8mjttMJ3F6XItc9XjPlYSlCsa HYk/IocvN9RNzPnTd/0x13/ktJep1vwaHBfhtrpo3/jflX5LaVN0bXPtJ0vnjk9EqopZ ZkDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TNVYDe807rXFprGHCwJ69e6uyKbChN+0aVPm+tJ314w=; b=vVCi1JKU7qyEbFFk6CLeJZoRxYPwYeBd3IoKqftWF8U1OgDEQWRKXd7chVd31QvM+H TxSSnXvQ4jPdi3jptNE9gTayz+49+K1mfO0eHRrnS/OQ8kVhK5KTv9DeawJiaDidLSgJ plq9o+cg/URgdEHESEAaJ6QbmTLJqcC4/Y3f8qylVVs/L76Q2Ji1UrG2F9V1U9O0s0tm ZoA003huOT0cT5WUFtw+GDw2js24GjAlmXvWN4fOn2GCapP9i+aJJnWWGnphKeSQjwrC IJhJ1Kw3LPqqmzmGxMc6M+/5+jWv8s5kEO0P5Q3nyeCDbSp72R9o7Xure1ER/4YQgQj8 TPIA== X-Gm-Message-State: AJIora8hG3Bz3ka5AE8eagQNABu9CIdj1Ch4AtazgFnNj6Iy0Qiaj9af 6EZcx+YT8cr6doA3Y8c09Lwvgg== X-Google-Smtp-Source: AGRyM1sbZ2BV6SDBpUkPaVel+EYBY+2WmOxAHnwUX9FzQhDZeKLC9SgSrmpkdCJb4Rq8HTj29D4iag== X-Received: by 2002:a17:907:9488:b0:722:e5c8:c647 with SMTP id dm8-20020a170907948800b00722e5c8c647mr5127672ejc.291.1656186037632; Sat, 25 Jun 2022 12:40:37 -0700 (PDT) Received: from [192.168.0.239] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id cb25-20020a0564020b7900b004359dafe822sm4584343edb.29.2022.06.25.12.40.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jun 2022 12:40:37 -0700 (PDT) Message-ID: <0bbee169-6fdc-b50e-87f7-1551dac821e2@linaro.org> Date: Sat, 25 Jun 2022 21:40:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] rpmsg: fix possible refcount leak in rpmsg_register_device_override() Content-Language: en-US To: Mathieu Poirier Cc: Hangyu Hua , bjorn.andersson@linaro.org, gregkh@linuxfoundation.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220624024120.11576-1-hbh25y@gmail.com> <20220624173621.GC1736477@p14s> <47db0cd8-c940-6e74-f8dc-8e3931e13d80@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 24/06/2022 20:43, Mathieu Poirier wrote: > On Fri, 24 Jun 2022 at 11:45, Krzysztof Kozlowski > wrote: >> >> On 24/06/2022 19:36, Mathieu Poirier wrote: >>> On Fri, Jun 24, 2022 at 10:41:20AM +0800, Hangyu Hua wrote: >>>> rpmsg_register_device_override need to call put_device to free vch when >>>> driver_set_override fails. >>>> >>>> Fix this by adding a put_device() to the error path. >>>> >>>> Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device") >>> >>> This is funny... Neither Bjorn nor I have reviewed this patch... >> >> It was a fix for commit in Greg's tree and Greg's pick it up after a >> week or something. I am not sure if that's actually funny that Greg has >> to pick it up without review :( >> > > The patch was sent out on April 19th and committed 3 days later on > April 22nd. Is 3 days the new patch review time standard? Neither 19th, nor 22nd are correct. The patch which you set you never reviewed, so commit bb17d110cbf2 was sent on 29th of April: https://lore.kernel.org/all/20220429195946.1061725-1-krzysztof.kozlowski@linaro.org/ And committed on 6 of May, which gives some time for review. Where did you see the other dates? Best regards, Krzysztof