From: Arun Kumar Neelakantam <aneela@codeaurora.org>
To: ohad@wizery.com, bjorn.andersson@linaro.org, clew@codeaurora.org,
robh+dt@kernel.org, arnaud.pouliquen@st.com,
andy.gross@linaro.org
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Arun Kumar Neelakantam <aneela@codeaurora.org>
Subject: [PATCH V4 8/9] rpmsg: glink: unregister rpmsg device during endpoint destroy
Date: Fri, 27 Jul 2018 17:47:28 +0530 [thread overview]
Message-ID: <1532693849-7037-9-git-send-email-aneela@codeaurora.org> (raw)
In-Reply-To: <1532693849-7037-1-git-send-email-aneela@codeaurora.org>
Rpmsg device unregister is not happening if channel close is triggered
from local side and causing re-registration of device failures.
Unregister rpmsg device for local close in endpoint destroy path.
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
---
drivers/rpmsg/qcom_glink_native.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 484b427..d849bc4 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1184,6 +1184,7 @@ static void qcom_glink_destroy_ept(struct rpmsg_endpoint *ept)
{
struct glink_channel *channel = to_glink_channel(ept);
struct qcom_glink *glink = channel->glink;
+ struct rpmsg_channel_info chinfo;
unsigned long flags;
spin_lock_irqsave(&channel->recv_lock, flags);
@@ -1191,6 +1192,13 @@ static void qcom_glink_destroy_ept(struct rpmsg_endpoint *ept)
spin_unlock_irqrestore(&channel->recv_lock, flags);
/* Decouple the potential rpdev from the channel */
+ if (channel->rpdev) {
+ strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
+ chinfo.src = RPMSG_ADDR_ANY;
+ chinfo.dst = RPMSG_ADDR_ANY;
+
+ rpmsg_unregister_device(glink->dev, &chinfo);
+ }
channel->rpdev = NULL;
qcom_glink_send_close_req(glink, channel);
@@ -1456,6 +1464,7 @@ static void qcom_glink_rx_close(struct qcom_glink *glink, unsigned int rcid)
rpmsg_unregister_device(glink->dev, &chinfo);
}
+ channel->rpdev = NULL;
qcom_glink_send_close_ack(glink, channel->rcid);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-07-27 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 12:17 [PATCH V4 0/9] Add chrdev and name query support for GLINK Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 1/9] dt-bindings: soc: qcom: Add label for GLINK bindings Arun Kumar Neelakantam
2018-07-30 22:30 ` Rob Herring
2018-07-27 12:17 ` [PATCH V4 2/9] rpmsg: glink: Store edge name for glink device Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 3/9] rpmsg: glink: Use complete_all for open states Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 4/9] rpmsg: Guard against null endpoint ops in destroy Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 5/9] rpmsg: glink: Add support for rpmsg glink chrdev Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 6/9] rpmsg: glink: Expose rpmsg name attr for glink Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 7/9] rpmsg: glink: Remove chunk size word align warning Arun Kumar Neelakantam
2018-07-27 12:17 ` Arun Kumar Neelakantam [this message]
2018-07-27 12:17 ` [PATCH V4 9/9] rpmsg: Add compat ioctl for rpmsg char driver Arun Kumar Neelakantam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532693849-7037-9-git-send-email-aneela@codeaurora.org \
--to=aneela@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox