public inbox for linux-remoteproc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot'
@ 2021-01-23 14:29 Paul Cercueil
  2021-01-26 22:50 ` Mathieu Poirier
  2021-02-09 17:40 ` patchwork-bot+linux-remoteproc
  0 siblings, 2 replies; 3+ messages in thread
From: Paul Cercueil @ 2021-01-23 14:29 UTC (permalink / raw)
  To: Ohad Ben-Cohen, Bjorn Andersson
  Cc: od, linux-mips, linux-remoteproc, linux-kernel, Paul Cercueil

Add a 'auto_boot' module parameter that instructs the remoteproc driver
whether or not it should auto-boot the remote processor, which will
default to "false", since the VPU in Ingenic SoCs does not really have
any predetermined function.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/remoteproc/ingenic_rproc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/remoteproc/ingenic_rproc.c b/drivers/remoteproc/ingenic_rproc.c
index 26e19e6143b7..e2618c36eaab 100644
--- a/drivers/remoteproc/ingenic_rproc.c
+++ b/drivers/remoteproc/ingenic_rproc.c
@@ -27,6 +27,11 @@
 #define AUX_CTRL_NMI		BIT(1)
 #define AUX_CTRL_SW_RESET	BIT(0)
 
+static bool auto_boot;
+module_param(auto_boot, bool, 0400);
+MODULE_PARM_DESC(auto_boot,
+		 "Auto-boot the remote processor [default=false]");
+
 struct vpu_mem_map {
 	const char *name;
 	unsigned int da;
@@ -172,6 +177,8 @@ static int ingenic_rproc_probe(struct platform_device *pdev)
 	if (!rproc)
 		return -ENOMEM;
 
+	rproc->auto_boot = auto_boot;
+
 	vpu = rproc->priv;
 	vpu->dev = &pdev->dev;
 	platform_set_drvdata(pdev, vpu);
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot'
  2021-01-23 14:29 [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot' Paul Cercueil
@ 2021-01-26 22:50 ` Mathieu Poirier
  2021-02-09 17:40 ` patchwork-bot+linux-remoteproc
  1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Poirier @ 2021-01-26 22:50 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Ohad Ben-Cohen, Bjorn Andersson, od, linux-mips, linux-remoteproc,
	linux-kernel

On Sat, Jan 23, 2021 at 02:29:56PM +0000, Paul Cercueil wrote:
> Add a 'auto_boot' module parameter that instructs the remoteproc driver
> whether or not it should auto-boot the remote processor, which will
> default to "false", since the VPU in Ingenic SoCs does not really have
> any predetermined function.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/remoteproc/ingenic_rproc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/remoteproc/ingenic_rproc.c b/drivers/remoteproc/ingenic_rproc.c
> index 26e19e6143b7..e2618c36eaab 100644
> --- a/drivers/remoteproc/ingenic_rproc.c
> +++ b/drivers/remoteproc/ingenic_rproc.c
> @@ -27,6 +27,11 @@
>  #define AUX_CTRL_NMI		BIT(1)
>  #define AUX_CTRL_SW_RESET	BIT(0)
>  
> +static bool auto_boot;
> +module_param(auto_boot, bool, 0400);
> +MODULE_PARM_DESC(auto_boot,
> +		 "Auto-boot the remote processor [default=false]");
> +
>  struct vpu_mem_map {
>  	const char *name;
>  	unsigned int da;
> @@ -172,6 +177,8 @@ static int ingenic_rproc_probe(struct platform_device *pdev)
>  	if (!rproc)
>  		return -ENOMEM;
>  
> +	rproc->auto_boot = auto_boot;
> +

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  	vpu = rproc->priv;
>  	vpu->dev = &pdev->dev;
>  	platform_set_drvdata(pdev, vpu);
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot'
  2021-01-23 14:29 [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot' Paul Cercueil
  2021-01-26 22:50 ` Mathieu Poirier
@ 2021-02-09 17:40 ` patchwork-bot+linux-remoteproc
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2021-02-09 17:40 UTC (permalink / raw)
  To: Paul Cercueil; +Cc: linux-remoteproc

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Sat, 23 Jan 2021 14:29:56 +0000 you wrote:
> Add a 'auto_boot' module parameter that instructs the remoteproc driver
> whether or not it should auto-boot the remote processor, which will
> default to "false", since the VPU in Ingenic SoCs does not really have
> any predetermined function.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> 
> [...]

Here is the summary with links:
  - remoteproc: ingenic: Add module parameter 'auto_boot'
    https://git.kernel.org/andersson/remoteproc/c/ec8207ae39dc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-09 17:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-23 14:29 [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot' Paul Cercueil
2021-01-26 22:50 ` Mathieu Poirier
2021-02-09 17:40 ` patchwork-bot+linux-remoteproc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox