* [PATCH -next] remoteproc: qcom: wcss: Fix return value check in q6v5_wcss_init_mmio()
@ 2021-03-19 9:41 'w00385741
2021-04-14 2:20 ` patchwork-bot+linux-remoteproc
0 siblings, 1 reply; 2+ messages in thread
From: 'w00385741 @ 2021-03-19 9:41 UTC (permalink / raw)
To: weiyongjun1, Andy Gross, Bjorn Andersson, Ohad Ben-Cohen,
Mathieu Poirier, Philipp Zabel, Govind Singh
Cc: linux-arm-msm, linux-remoteproc, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/remoteproc/qcom_q6v5_wcss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
index 71ec1a451e35..6f7d940d4431 100644
--- a/drivers/remoteproc/qcom_q6v5_wcss.c
+++ b/drivers/remoteproc/qcom_q6v5_wcss.c
@@ -829,8 +829,8 @@ static int q6v5_wcss_init_mmio(struct q6v5_wcss *wcss,
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qdsp6");
wcss->reg_base = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
- if (IS_ERR(wcss->reg_base))
- return PTR_ERR(wcss->reg_base);
+ if (!wcss->reg_base)
+ return -ENOMEM;
if (wcss->version == WCSS_IPQ8074) {
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rmb");
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-14 2:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-19 9:41 [PATCH -next] remoteproc: qcom: wcss: Fix return value check in q6v5_wcss_init_mmio() 'w00385741
2021-04-14 2:20 ` patchwork-bot+linux-remoteproc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox