From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Henri Roosen <henri.roosen@ginzinger.com>,
ohad@wizery.com, linux-remoteproc@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rpmsg: Release rpmsg devices in backends
Date: Sun, 25 Jun 2017 14:28:56 -0700 [thread overview]
Message-ID: <20170625212856.GE26155@builder> (raw)
In-Reply-To: <e6bdf431-8950-8543-cec0-bbf9c9a270c2@ti.com>
On Fri 02 Jun 17:28 PDT 2017, Suman Anna wrote:
> Hi Bjorn,
>
> On 06/02/2017 05:07 AM, Henri Roosen wrote:
> > My suggestion would be to additionally change/fix
> > rpmsg_register_device() so it will not overwrite the release callback.
[..]
> FWIW, I didn't run into any rpmsg device memory leaks even without this
> patch with booting and shutting down of remoteproc devices. The
> virtio_rpmsg_channel structure inherits the struct rpmsg_device and is
> the one that gets allocated, and the release function plugged in
> rpmsg_release_device is operating on the rpmsg_device pointer, but both
> are actually the same pointer.
>
> Did you run into any memory leaks that required you to have this patch?
>
I did not see any memory leaks, because it happens that the pointers are
the same in all current cases.
But the code is wrong and should be fixed, thanks for pointing this out
Henri!
Regards,
Bjorn
prev parent reply other threads:[~2017-06-25 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 5:18 [PATCH] rpmsg: Release rpmsg devices in backends Bjorn Andersson
2017-06-02 10:07 ` Henri Roosen
2017-06-03 0:28 ` Suman Anna
2017-06-25 21:28 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170625212856.GE26155@builder \
--to=bjorn.andersson@linaro.org \
--cc=henri.roosen@ginzinger.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).