From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jitendra Sharma <shajit@codeaurora.org>
Cc: linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] remoteproc: Remove null character write of shared mem
Date: Wed, 7 Feb 2018 07:27:53 -0800 [thread overview]
Message-ID: <20180207152753.GO9465@builder> (raw)
In-Reply-To: <1518009762-26480-1-git-send-email-shajit@codeaurora.org>
On Wed 07 Feb 05:22 PST 2018, Jitendra Sharma wrote:
> remoteproc is writing '\0' in the shared mem region. This
> region is shared among multiple clients that are also trying
> to read. Hence they miss first character.
>
> Remove this null character write, as this mem area is
> supposed to be Read only.
>
> Further during every subsystem reboot, this region is
> initialized with default, hence no need to write this
> region.
Thanks for your patch Jitendra!
The write was removed from the downstream kernel in msm-4.9, late last
year. Can you please confirm that you describe here is valid for
platforms supported prior to this change as well?
E.g. is what you're describing true for wcnss on 8064, adsp on 8974 and
mpss on 8916?
Regards,
Bjorn
next prev parent reply other threads:[~2018-02-07 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 13:22 [PATCH] remoteproc: Remove null character write of shared mem Jitendra Sharma
2018-02-07 15:27 ` Bjorn Andersson [this message]
2018-02-08 9:12 ` Jitendra Sharma
2018-02-12 18:39 ` Bjorn Andersson
2018-02-13 7:12 ` Jitendra Sharma
2018-04-05 8:59 ` Jitendra Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207152753.GO9465@builder \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=shajit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox