From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
sricharan@codeaurora.org, sibis@codeaurora.org
Subject: Re: [PATCH] remoteproc: Populate hardcoded param using driver data
Date: Fri, 5 Oct 2018 23:30:33 -0700 [thread overview]
Message-ID: <20181006063033.GG12063@builder> (raw)
In-Reply-To: <1538215641-25665-1-git-send-email-govinds@codeaurora.org>
On Sat 29 Sep 03:07 PDT 2018, Govind Singh wrote:
> Q6 based WiFi fw loading is supported across
> different targets, ex: IPQ8074/QCS404. In order to
> support different fw names/pas id etc, populate
> hardcoded param using driver data.
>
This patch prepares the driver for the introduction of some variation of
some of the given parameters. Please submit this patch together with the
patch introducing that new code.
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
[..]
> +static const struct wcss_data wcss_ipq8074_res_init = {
> + .firmware_name = "IPQ8074/q6_fw.mdt",
> + .crash_reason_smem = 421,
> + .pas_handover = NULL,
Please don't inherit my broken indentation from the adsp driver ;)
> +};
> +
> static const struct of_device_id q6v5_wcss_of_match[] = {
> - { .compatible = "qcom,ipq8074-wcss-pil" },
> + { .compatible = "ipq8074-wcss-pil", .data = &wcss_ipq8074_res_init },
You lost qcom, in the compatible here.
> +
Regards,
Bjorn
prev parent reply other threads:[~2018-10-06 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 10:07 [PATCH] remoteproc: Populate hardcoded param using driver data Govind Singh
2018-10-01 20:34 ` Suman Anna
2018-10-06 6:30 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006063033.GG12063@builder \
--to=bjorn.andersson@linaro.org \
--cc=govinds@codeaurora.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sibis@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox