From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 11 Nov 2019 23:08:47 -0800 From: Bjorn Andersson Subject: Re: [PATCH v20 3/4] rpmsg: add rpmsg support for mt8183 SCP. Message-ID: <20191112070845.GR3108315@builder> References: <20191014075812.181942-1-pihsun@chromium.org> <20191014075812.181942-4-pihsun@chromium.org> <20191111231023.GD3108315@builder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Pi-Hsun Shih Cc: Ohad Ben-Cohen , Matthias Brugger , open list , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" List-ID: On Mon 11 Nov 22:42 PST 2019, Pi-Hsun Shih wrote: > On Tue, Nov 12, 2019 at 7:10 AM Bjorn Andersson > wrote: > > On Mon 14 Oct 00:58 PDT 2019, Pi-Hsun Shih wrote: > > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c [..] > > > +static struct mtk_rpmsg_info mtk_scp_rpmsg_info = { > > > + .send_ipi = scp_ipi_send, > > > + .register_ipi = scp_ipi_register, > > > + .unregister_ipi = scp_ipi_unregister, > > > > These are exported symbols, so unless you see a need to support > > alternative implementations in the near future just skip the function > > pointers and call them directly. > > > > Yes there is request from MTK that they do want to reuse the mtk_rpmsg > driver for things other than mtk_scp, so there's a need to support > alternative implementations for this. > Fair enough, let's leave it like this for now! Looking forward to the next revision of the patches. Regards, Bjorn