From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 21 Feb 2020 14:56:05 -0700 From: Mathieu Poirier Subject: Re: [PATCH 5/9] remoteproc: imx_rproc: parse early-booted property Message-ID: <20200221215605.GC10368@xps15> References: <1582097265-20170-1-git-send-email-peng.fan@nxp.com> <1582097265-20170-6-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582097265-20170-6-git-send-email-peng.fan@nxp.com> To: peng.fan@nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: On Wed, Feb 19, 2020 at 03:27:41PM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > If early-property exists, there is no need to check syscon. > Just mark early_boot as true. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index b9fabe269fd2..e31ea1090cf3 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -483,7 +483,9 @@ static int imx_rproc_configure_mode(struct imx_rproc *priv) > int ret; > u32 val; > > - if (of_get_property(dev->of_node, "early-booted", NULL)) { > + if (dcfg->variants == IMX7ULP) { Where does dcfg->variants comes from? This patch doesn't compile, nor does the one before it. I will not review another patchset like that. > + priv->early_boot = true; > + } else if (of_get_property(dev->of_node, "early-booted", NULL)) { > priv->early_boot = true; > } else { > ret = regmap_read(priv->regmap, dcfg->src_reg, &val); > @@ -509,15 +511,17 @@ static int imx_rproc_probe(struct platform_device *pdev) > struct rproc *rproc; > struct regmap_config config = { .name = "imx-rproc" }; > const struct imx_rproc_dcfg *dcfg; > - struct regmap *regmap; > + struct regmap *regmap = NULL; > int ret; > > - regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > - if (IS_ERR(regmap)) { > - dev_err(dev, "failed to find syscon\n"); > - return PTR_ERR(regmap); > + if (!of_get_property(np, "early-booted", NULL)) { > + regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > + if (IS_ERR(regmap)) { > + dev_err(dev, "failed to find syscon\n"); > + return PTR_ERR(regmap); > + } > + regmap_attach_dev(dev, regmap, &config); > } > - regmap_attach_dev(dev, regmap, &config); > > /* set some other name then imx */ > rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, > -- > 2.16.4 >