From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 27 Feb 2020 21:35:53 -0800 From: Bjorn Andersson Subject: Re: [PATCH v4 2/3] dt-bindings: soc: qcom: apr: Add protection domain bindings Message-ID: <20200228053550.GD210720@yoga> References: <20200226170001.24234-1-sibis@codeaurora.org> <20200226170001.24234-3-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226170001.24234-3-sibis@codeaurora.org> To: Sibi Sankar Cc: srinivas.kandagatla@linaro.org, robh+dt@kernel.org, agross@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tsoni@codeaurora.org, vnkgutta@codeaurora.org List-ID: On Wed 26 Feb 09:00 PST 2020, Sibi Sankar wrote: > Qualcomm SoCs (starting with MSM8998) allow for multiple protection > domains (PDs) to run on the same Q6 sub-system. This allows for > services like AVS AUDIO to have their own separate address space and > crash/recover without disrupting the other PDs running on the same Q6 > ADSP. Add "qcom,protection-domain" bindings to capture the dependencies > between the APR service and the PD on which the apr service runs. > Reviewed-by: Bjorn Andersson > Signed-off-by: Sibi Sankar > --- > .../devicetree/bindings/soc/qcom/qcom,apr.txt | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > index db501269f47b8..f8fa71f5d84ba 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > @@ -45,6 +45,18 @@ by the individual bindings for the specific service > 12 - Ultrasound stream manager. > 13 - Listen stream manager. > > +- qcom,protection-domain > + Usage: optional > + Value type: > + Definition: Must list the protection domain service name and path > + that the particular apr service has a dependency on. > + Possible values are : > + "avs/audio", "msm/adsp/audio_pd". > + "kernel/elf_loader", "msm/modem/wlan_pd". > + "tms/servreg", "msm/adsp/audio_pd". > + "tms/servreg", "msm/modem/wlan_pd". > + "tms/servreg", "msm/slpi/sensor_pd". > + > = EXAMPLE > The following example represents a QDSP based sound card on a MSM8996 device > which uses apr as communication between Apps and QDSP. > @@ -82,3 +94,41 @@ which uses apr as communication between Apps and QDSP. > ... > }; > }; > + > += EXAMPLE 2 > +The following example represents a QDSP based sound card with protection domain > +dependencies specified. Here some of the apr services are dependent on services > +running on protection domain hosted on ADSP/SLPI remote processors while others > +have no such dependency. > + > + apr { > + compatible = "qcom,apr-v2"; > + qcom,glink-channels = "apr_audio_svc"; > + qcom,apr-domain = ; > + > + q6core { > + compatible = "qcom,q6core"; > + reg = ; > + }; > + > + q6afe: q6afe { > + compatible = "qcom,q6afe"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + ... > + }; > + > + q6asm: q6asm { > + compatible = "qcom,q6asm"; > + reg = ; > + qcom,protection-domain = "tms/servreg", "msm/slpi/sensor_pd"; > + ... > + }; > + > + q6adm: q6adm { > + compatible = "qcom,q6adm"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + ... > + }; > + }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project