Re: [PATCH v2 08/12] remoteproc: stm32: Introduce new start ops for synchronisation

Arnaud POULIQUEN
2020-04-29T14:50:13Z

On 4/24/20 10:25 PM, Mathieu Poirier wrote:
> Introduce new start functions to be used when synchonising with an MCU.
>
> Mainly based on the work published by Arnaud Pouliquen [1].
>
> [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Thanks,
Arnaud

> ---
> drivers/remoteproc/stm32_rproc.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 8ba69e903851..404f17a97095 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -449,6 +449,13 @@ static int stm32_rproc_start(struct rproc *rproc)
> return stm32_rproc_set_hold_boot(rproc, true);
> }
>
> +static int stm32_rproc_sync_start(struct rproc *rproc)
> +{
> + stm32_rproc_add_coredump_trace(rproc);
> +
> + return stm32_rproc_set_hold_boot(rproc, true);
> +}
> +
> static int stm32_rproc_stop(struct rproc *rproc)
> {
> struct stm32_rproc *ddata = rproc->priv;
> @@ -522,6 +529,10 @@ static struct rproc_ops st_rproc_ops = {
> .get_boot_addr = rproc_elf_get_boot_addr,
> };
>
> +static __maybe_unused struct rproc_ops st_rproc_sync_ops = {
> + .start = stm32_rproc_sync_start,
> +};
> +
> static const struct of_device_id stm32_rproc_match[] = {
> { .compatible = "st,stm32mp1-m4" },
> {},
>