Re: [PATCH v4 0/4] Add a vhost RPMsg API

Michael S. Tsirkin
2020-08-04T14:10:39Z

On Tue, Aug 04, 2020 at 03:19:19PM +0200, Guennadi Liakhovetski wrote:
> Hi Michael,
>
> On Tue, Aug 04, 2020 at 08:26:53AM -0400, Michael S. Tsirkin wrote:
> > On Wed, Jul 22, 2020 at 05:09:23PM +0200, Guennadi Liakhovetski wrote:
> > > Hi,
> > >
> > > Now that virtio-rpmsg endianness fixes have been merged we can
> > > proceed with the next step.
> >
> > OK my attempts to resolve conflicts just created a mess.
>
> You just need to apply my previous patch for virtio-rpmsg first
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/rpmsg/virtio_rpmsg_bus.c?id=111d1089700cdb752681ef44f54ab6137736f5c2
> Then this series should apply cleanly.
>
> Thanks
> Guennadi

Hmm. Could you test the vhost branch in my tree, and tell me if that looks
good to you?

> > I dropped these for now, could you pls rebase on top
> > of linux-next branch in my tree, and repost?
> > Thanks!
> >
> >
> > > v4:
> > > - add endianness conversions to comply with the VirtIO standard
> > >
> > > v3:
> > > - address several checkpatch warnings
> > > - address comments from Mathieu Poirier
> > >
> > > v2:
> > > - update patch #5 with a correct vhost_dev_init() prototype
> > > - drop patch #6 - it depends on a different patch, that is currently
> > > an RFC
> > > - address comments from Pierre-Louis Bossart:
> > > * remove "default n" from Kconfig
> > >
> > > Linux supports RPMsg over VirtIO for "remote processor" / AMP use
> > > cases. It can however also be used for virtualisation scenarios,
> > > e.g. when using KVM to run Linux on both the host and the guests.
> > > This patch set adds a wrapper API to facilitate writing vhost
> > > drivers for such RPMsg-based solutions. The first use case is an
> > > audio DSP virtualisation project, currently under development, ready
> > > for review and submission, available at
> > > https://github.com/thesofproject/linux/pull/1501/commits
> > >
> > > Thanks
> > > Guennadi
> > >
> > > Guennadi Liakhovetski (4):
> > > vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl
> > > rpmsg: move common structures and defines to headers
> > > rpmsg: update documentation
> > > vhost: add an RPMsg API
> > >
> > > Documentation/rpmsg.txt | 6 +-
> > > drivers/rpmsg/virtio_rpmsg_bus.c | 78 +------
> > > drivers/vhost/Kconfig | 7 +
> > > drivers/vhost/Makefile | 3 +
> > > drivers/vhost/rpmsg.c | 375 +++++++++++++++++++++++++++++++
> > > drivers/vhost/vhost_rpmsg.h | 74 ++++++
> > > include/linux/virtio_rpmsg.h | 83 +++++++
> > > include/uapi/linux/rpmsg.h | 3 +
> > > include/uapi/linux/vhost.h | 4 +-
> > > 9 files changed, 553 insertions(+), 80 deletions(-)
> > > create mode 100644 drivers/vhost/rpmsg.c
> > > create mode 100644 drivers/vhost/vhost_rpmsg.h
> > > create mode 100644 include/linux/virtio_rpmsg.h
> > >
> > > --
> > > 2.27.0
> >