Re: [PATCH v9 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

Michael Auchter
2020-08-27T14:48:33Z

Hey Ben,

On Wed, Aug 26, 2020 at 06:58:05PM -0700, Ben Levinsky wrote:
> v10:
> - add include types.h to xlnx-zynqmp.h for compilation

I appreciate the quick turnaround on v10, but it looks like much of my
feedback on v9 went unacknowledged.

Most concerning is the fact that loading firmware on to R5 1 is _still_
broken in v10 due to the incorrect TCM banks being used.

Thanks,
Michael

>
> Ben Levinsky (5):
> firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU
> configuration.
> firmware: xilinx: Add shutdown/wakeup APIs
> firmware: xilinx: Add RPU configuration APIs
> dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc
> bindings
> remoteproc: Add initial zynqmp R5 remoteproc driver
>
> .../xilinx,zynqmp-r5-remoteproc.yaml | 113 +++
> drivers/firmware/xilinx/zynqmp.c | 86 ++
> drivers/remoteproc/Kconfig | 10 +
> drivers/remoteproc/Makefile | 1 +
> drivers/remoteproc/zynqmp_r5_remoteproc.c | 898 ++++++++++++++++++
> include/linux/firmware/xlnx-zynqmp.h | 63 ++
> 6 files changed, 1171 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
> create mode 100644 drivers/remoteproc/zynqmp_r5_remoteproc.c
>
> --
> 2.17.1
>