From: Dan Carpenter <dan.carpenter@oracle.com>
To: erin.lo@mediatek.com
Cc: linux-remoteproc@vger.kernel.org
Subject: [bug report] remoteproc/mediatek: add SCP support for mt8183
Date: Wed, 16 Sep 2020 17:54:25 +0300 [thread overview]
Message-ID: <20200916145425.GA768671@mwanda> (raw)
Hello Erin Lo,
The patch 63c13d61eafe: "remoteproc/mediatek: add SCP support for
mt8183" from Nov 12, 2019, leads to the following static checker
warning:
drivers/remoteproc/mtk_scp_ipi.c:34 scp_ipi_register()
error: we previously assumed 'scp' could be null (see line 33)
drivers/remoteproc/mtk_scp_ipi.c
28 int scp_ipi_register(struct mtk_scp *scp,
29 u32 id,
30 scp_ipi_handler_t handler,
31 void *priv)
32 {
33 if (!scp) {
^^^^
Check
34 dev_err(scp->dev, "scp device is not ready\n");
^^^^^^^^
NULL dereference
35 return -EPROBE_DEFER;
36 }
37
38 if (WARN_ON(id >= SCP_IPI_MAX) || WARN_ON(handler == NULL))
39 return -EINVAL;
40
41 scp_ipi_lock(scp, id);
42 scp->ipi_desc[id].handler = handler;
regards,
dan carpenter
reply other threads:[~2020-09-16 21:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916145425.GA768671@mwanda \
--to=dan.carpenter@oracle.com \
--cc=erin.lo@mediatek.com \
--cc=linux-remoteproc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox