RE: [PATCH 03/13] remoteproc: Add new RPROC_ATTACHED state

Peng Fan
2020-10-15T01:31:24Z

> Subject: [PATCH 03/13] remoteproc: Add new RPROC_ATTACHED state
>
> Add a new RPROC_ATTACHED state to take into account scenarios where the
> remoteproc core needs to attach to a remote processor that is booted by
> another entity.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> drivers/remoteproc/remoteproc_sysfs.c | 1 +
> include/linux/remoteproc.h | 7 +++++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_sysfs.c
> b/drivers/remoteproc/remoteproc_sysfs.c
> index eea514cec50e..2d575e6c9eb8 100644
> --- a/drivers/remoteproc/remoteproc_sysfs.c
> +++ b/drivers/remoteproc/remoteproc_sysfs.c
> @@ -84,6 +84,7 @@ static const char * const rproc_state_string[] = {
> [RPROC_RUNNING] = "running",
> [RPROC_CRASHED] = "crashed",
> [RPROC_DELETED] = "deleted",
> + [RPROC_ATTACHED] = "attached",
> [RPROC_DETACHED] = "detached",
> [RPROC_LAST] = "invalid",
> };
> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index
> 2fa68bf5aa4f..4e107615121a 100644
> --- a/include/linux/remoteproc.h
> +++ b/include/linux/remoteproc.h
> @@ -403,6 +403,8 @@ struct rproc_ops {
> * @RPROC_RUNNING: device is up and running
> * @RPROC_CRASHED: device has crashed; need to start recovery
> * @RPROC_DELETED: device is deleted
> + * @RPROC_ATTACHED: device has been booted by another entity and
> the core
> + * has attached to it
> * @RPROC_DETACHED: device has been booted by another entity and
> waiting
> * for the core to attach to it
> * @RPROC_LAST: just keep this one at the end
> @@ -419,8 +421,9 @@ enum rproc_state {
> RPROC_RUNNING = 2,
> RPROC_CRASHED = 3,
> RPROC_DELETED = 4,
> - RPROC_DETACHED = 5,
> - RPROC_LAST = 6,
> + RPROC_ATTACHED = 5,
> + RPROC_DETACHED = 6,
> + RPROC_LAST = 7,
> };
>
> /**
> --

Reviewed-by: Peng Fan <peng.fan@nxp.com>