Re: [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver

Mathieu Poirier
2020-11-19T17:33:35Z

On Thu, Nov 19, 2020 at 06:10:51PM +0100, Guennadi Liakhovetski wrote:
> Hi Mathieu,
>
> I haven't tested it yet, but I've compared it to the previous version
> and all the changed except the one, mentioned by Arnaud, seem to be
> there! So, let's just fix this one and should be good to go!
>

Apologies for the brain bug - the code got lost in the thread...

> Thanks
> Guennadi
>
> On Thu, Nov 19, 2020 at 03:52:50PM +0100, Arnaud POULIQUEN wrote:
>
> [snip]
>
> > As Guennadi mentionned in a previous mail
> > a kfree(vch) is missing on error
> >
> > @@ -949,10 +949,11 @@ static int rpmsg_probe(struct virtio_device *vdev)
> > dev_info(&vdev->dev, "rpmsg host is online\n");
> >
> > return 0;
> >
> > free_coherent:
> > + kfree(vch);
> > dma_free_coherent(vdev->dev.parent, total_buf_space,
> > bufs_va, vrp->bufs_dma);
> > vqs_del:
> >
> > Otherwise i tested this series successfully.
> >
> > Thanks,
> > Arnaud