From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
od@zcrc.me, linux-mips@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot'
Date: Tue, 26 Jan 2021 15:50:15 -0700 [thread overview]
Message-ID: <20210126225015.GA1100385@xps15> (raw)
In-Reply-To: <20210123142956.17865-1-paul@crapouillou.net>
On Sat, Jan 23, 2021 at 02:29:56PM +0000, Paul Cercueil wrote:
> Add a 'auto_boot' module parameter that instructs the remoteproc driver
> whether or not it should auto-boot the remote processor, which will
> default to "false", since the VPU in Ingenic SoCs does not really have
> any predetermined function.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/remoteproc/ingenic_rproc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/remoteproc/ingenic_rproc.c b/drivers/remoteproc/ingenic_rproc.c
> index 26e19e6143b7..e2618c36eaab 100644
> --- a/drivers/remoteproc/ingenic_rproc.c
> +++ b/drivers/remoteproc/ingenic_rproc.c
> @@ -27,6 +27,11 @@
> #define AUX_CTRL_NMI BIT(1)
> #define AUX_CTRL_SW_RESET BIT(0)
>
> +static bool auto_boot;
> +module_param(auto_boot, bool, 0400);
> +MODULE_PARM_DESC(auto_boot,
> + "Auto-boot the remote processor [default=false]");
> +
> struct vpu_mem_map {
> const char *name;
> unsigned int da;
> @@ -172,6 +177,8 @@ static int ingenic_rproc_probe(struct platform_device *pdev)
> if (!rproc)
> return -ENOMEM;
>
> + rproc->auto_boot = auto_boot;
> +
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> vpu = rproc->priv;
> vpu->dev = &pdev->dev;
> platform_set_drvdata(pdev, vpu);
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-01-27 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 14:29 [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot' Paul Cercueil
2021-01-26 22:50 ` Mathieu Poirier [this message]
2021-02-09 17:40 ` patchwork-bot+linux-remoteproc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126225015.GA1100385@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=od@zcrc.me \
--cc=ohad@wizery.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox