From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A25EEC433DB for ; Wed, 24 Feb 2021 20:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 587CA64E09 for ; Wed, 24 Feb 2021 20:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235772AbhBXUdZ (ORCPT ); Wed, 24 Feb 2021 15:33:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235366AbhBXUdX (ORCPT ); Wed, 24 Feb 2021 15:33:23 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 124D6C061788 for ; Wed, 24 Feb 2021 12:32:43 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id u11so1893234plg.13 for ; Wed, 24 Feb 2021 12:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=erKUdffAM3F5huUC4FQIYg8RAIvLdOL+DyshS4q8nGY=; b=H/+3WVeTU77f/r9XgYsKu6ikAyhaaXZFJ5G7H3yfsURPxDGY+qi0vZ6j/LsqcPcxPs FYAbSbt7ryauf3olMsOc9mHWKt3Bk5mAjLPsk4kSIXODu4Y8Vj8XfY+JZNFzdlv5Mc9u FOdX/FSdtNbg0Htp65PoH6yaUmGKYCSASxE9BbMHCeR3q3RQl/dCqi3xWodJ4U5i+8eg ZKs4YA+YOpvc78mMluLBDUMBUIc6VF6p2h2bg4QHniyHza9ku8IloFNu1LCR9jZLv578 3RoS9EdlDqRfPTEthop532muh/GQjHYQxF8RJe+yoRYk4tGY4ZH+e8z6YitIGjNmPClb 52ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=erKUdffAM3F5huUC4FQIYg8RAIvLdOL+DyshS4q8nGY=; b=OaKZ2a6igqTNLuW6otpHfDiDpxet+6ehRZzNx/UPMJszHEo76ZtufgQt0/HV5xQCZW CFfs3MCh3BUDoYztLCAPDYrJVA8fThTdRIK/dpe2I3o1fIb3R2zgSICJO8ZZOwX6aK08 GqlPm6S+Agj4a6TWEUsDMyIaE0FWjyS3Zq7SqofsPvHoPHSDjbLdC3YVS4Otb5YECkNK LpZ6h+A5budxjAr4nysvJN5IkOsPVldcdhXxpGRVmYp/G0KVW10yJl7HKryPFeNK9u1u MlRJ1LIkBI7PbZ+RnKtrXjrO0ps+UIjWAMpCbm9NDFV1t5DEAwc0vWD7ysqhkG4U+o1k gpSA== X-Gm-Message-State: AOAM532ep1XhJmgPdPXHG91adw5PvKNU+HgiE065AO6KMyXhGi9IRjxm Vy8meWQcvzHKyX5SaKud5ZV2dw== X-Google-Smtp-Source: ABdhPJwlEM1ksnGB9rn6NHo9aS17OOewNS+m1QpFQK5YQefYAo0qpxD7HQvcQNedMN4ZDsJdiiCluA== X-Received: by 2002:a17:90a:db90:: with SMTP id h16mr6403792pjv.2.1614198762587; Wed, 24 Feb 2021 12:32:42 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id q23sm3776645pfn.213.2021.02.24.12.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 12:32:42 -0800 (PST) Date: Wed, 24 Feb 2021 13:32:40 -0700 From: Mathieu Poirier To: Yang Li Cc: ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: pru: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Message-ID: <20210224203240.GA3512860@xps15> References: <1614154829-42461-1-git-send-email-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614154829-42461-1-git-send-email-yang.lee@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Wed, Feb 24, 2021 at 04:20:29PM +0800, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/remoteproc/pru_rproc.c:247:0-23: WARNING: > pru_rproc_debug_ss_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/remoteproc/pru_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > index 2667919..04a9d99 100644 > --- a/drivers/remoteproc/pru_rproc.c > +++ b/drivers/remoteproc/pru_rproc.c > @@ -244,7 +244,7 @@ static int pru_rproc_debug_ss_get(void *data, u64 *val) > > return 0; > } > -DEFINE_SIMPLE_ATTRIBUTE(pru_rproc_debug_ss_fops, pru_rproc_debug_ss_get, > +DEFINE_DEBUGFS_ATTRIBUTE(pru_rproc_debug_ss_fops, pru_rproc_debug_ss_get, > pru_rproc_debug_ss_set, "%llu\n"); Reviewed-by: Mathieu Poirier > > /* > -- > 1.8.3.1 >