From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8383C433DB for ; Fri, 26 Mar 2021 08:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A35B861A2B for ; Fri, 26 Mar 2021 08:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhCZIMv (ORCPT ); Fri, 26 Mar 2021 04:12:51 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:58038 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230007AbhCZIMt (ORCPT ); Fri, 26 Mar 2021 04:12:49 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12Q84opY175031; Fri, 26 Mar 2021 08:12:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=sst2tKBKgYuv4Lz0DarDYV6i6MKcwVcBTIWBVplgT2A=; b=qa+1jWTRIeRkqCSNyXLBhG3H0BJVpJxNn/RkjWkmR13alsb4BcjsdFw8fqHG734dNm1t obHj00H1I4OiK2Q9q5p54LE8DECpO5rARaUn0Qjhmc/nsLVJ0hsRRUkZjvxXCFOf8gqZ OkNSHk41j6w9C/DxKBEhMrFUkl3Upsp1sPoeNzKKmbxjHyYR4WsS3/Tmo8QHF+4Jqnxz BipNmClcGonwaefPsTwDN5XrEMrNC3gLFjr1VwJqnyR/Q97EpnEknX6tbiyiBA4JzlJ1 Mfzd5vfS4ECZX4oFy9JSdkG89wlRPoOLnZte8MRMYeQNwQaL1mjYyWoc1pZwmOTzBgup 4Q== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 37h13rs692-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Mar 2021 08:12:31 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12Q8BKmE008381; Fri, 26 Mar 2021 08:12:30 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 37h1413ux5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Mar 2021 08:12:30 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 12Q8CR69029129; Fri, 26 Mar 2021 08:12:27 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 26 Mar 2021 01:12:27 -0700 Date: Fri, 26 Mar 2021 11:12:17 +0300 From: Dan Carpenter To: Wei Yongjun Cc: Govind Singh , Andy Gross , Bjorn Andersson , Ohad Ben-Cohen , Mathieu Poirier , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next v2] remoteproc: qcom: wcss: Fix wrong pointer passed to PTR_ERR() Message-ID: <20210326081217.GX1667@kadam> References: <20210326024741.841267-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326024741.841267-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9934 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103260059 X-Proofpoint-ORIG-GUID: cG-oKy_dxTRWpJdMEHH_HUqYXxIOQllD X-Proofpoint-GUID: cG-oKy_dxTRWpJdMEHH_HUqYXxIOQllD X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9934 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103260058 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri, Mar 26, 2021 at 02:47:41AM +0000, Wei Yongjun wrote: > PTR_ERR should access the value just tested by IS_ERR, otherwise > the wrong error code will be returned. > > This commit fix it by return 'ret' directly. > > Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > v1 -> v2: just return ret as Dan's suggestion. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter